From fd447e9a754ee6781c401e3db363305fb61d0f47 Mon Sep 17 00:00:00 2001 From: Carlo Costino Date: Wed, 9 Oct 2024 14:20:10 -0600 Subject: [PATCH] Swap out config variables for env variables This changeset swaps the CF_USERNAME and CF_PASSWORD config vars to be proper env vars so they can be read in as expected. Signed-off-by: Carlo Costino --- .github/actions/deploy-proxy/action.yml | 6 ------ .github/workflows/deploy.yml | 5 +++-- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/.github/actions/deploy-proxy/action.yml b/.github/actions/deploy-proxy/action.yml index 393dd4b45..0ffc05066 100644 --- a/.github/actions/deploy-proxy/action.yml +++ b/.github/actions/deploy-proxy/action.yml @@ -1,12 +1,6 @@ name: Deploy egress proxy description: Set egress space security groups and deploy proxy inputs: - cf_username: - description: The username to authenticate with. - required: true - cf_password: - description: The password to authenticate with. - required: true cf_org: description: The org the target app exists in. required: true diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index abcac49a0..72614b09d 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -109,9 +109,10 @@ jobs: - name: Deploy egress proxy #if: steps.changed-egress-config.outputs.any_changed == 'true' uses: ./.github/actions/deploy-proxy + env: + CF_USERNAME: ${{ secrets.CF_USERNAME }} + CF_PASSWORD: ${{ secrets.CF_PASSWORD }} with: - cf_username: ${{ secrets.CLOUDGOV_USERNAME }} - cf_password: ${{ secrets.CLOUDGOV_PASSWORD }} cf_org: gsa-tts-benefits-studio cf_space: notify-staging app: notify-admin-staging