From 9a8dda2f7a703e74c3cafa7c2192c91f5c0b9119 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Tue, 14 Feb 2017 11:33:55 +0000 Subject: [PATCH 1/5] Fix missing skiplink target on product page MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We didn’t have an element with an `id` of `content` on the product page because we didn’t want the styles that come with it (from GOV.UK Elements here: https://github.com/alphagov/govuk_elements/blob/d6226bd2c8c7e256f995c0f519daaa4035c6bd54/public/sass/elements/_layout.scss#L9-L20) This meant that the skiplink didn’t work on the product page because it’s target was not on the page. The skiplink’s target is hardcoded to point at `#content`. The proper way to fix this would be to not hardcode the skiplink to point at `#content`, ie what this pull request does: https://github.com/alphagov/govuk_template/pull/275 Until that is merged, we can hack around the problem by overriding the styles that Elements applies to `#content`, which is what this pull request does. --- app/assets/stylesheets/app.scss | 4 ++++ app/templates/views/signedout.html | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/app/assets/stylesheets/app.scss b/app/assets/stylesheets/app.scss index 570d997e0..2d45890f4 100644 --- a/app/assets/stylesheets/app.scss +++ b/app/assets/stylesheets/app.scss @@ -249,3 +249,7 @@ details .arrow { .block-label input[disabled] { opacity: 0.5; } + +#content.override-elements-content { + padding-bottom: 0; +} diff --git a/app/templates/views/signedout.html b/app/templates/views/signedout.html index 1f652175e..c367cfe9f 100644 --- a/app/templates/views/signedout.html +++ b/app/templates/views/signedout.html @@ -10,8 +10,8 @@ {% block maincolumn_content %} -
-
+
+