darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-18 05:29:38 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix small issues identified in PR review

Browse Source 
In response to: [^1], [^2], [^3], [^4], [^5] and [^6].

[^1]: https://github.com/alphagov/notifications-admin/pull/4182#discussion_r825824485
[^2]: https://github.com/alphagov/notifications-admin/pull/4182#discussion_r825824805
[^3]: https://github.com/alphagov/notifications-admin/pull/4182#discussion_r825857745
[^4]: https://github.com/alphagov/notifications-admin/pull/4182#discussion_r825859850
[^5]: https://github.com/alphagov/notifications-admin/pull/4182#discussion_r825859982
[^6]: https://github.com/alphagov/notifications-admin/pull/4182#discussion_r826001823
This commit is contained in:
Ben Thorner
2022-03-15 11:37:45 +00:00
parent 857b8b04b0
commit fa3e6435a6
2 changed files with 27 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/main/forms.py
View File

@@ -2196,11 +2196,11 @@ class ChooseBrandingForm(StripWhitespaceForm):
if self.something_else_is_only_option:
self.options.data = self.FALLBACK_OPTION_VALUE
@staticmethod
def get_available_choices(service, branding_type):
@classmethod
def get_available_choices(cls, service, branding_type):
return (
list(branding.get_available_choices(service, branding_type)) +
[ChooseBrandingForm.FALLBACK_OPTION]
[cls.FALLBACK_OPTION]
)
@property
@@ -2221,12 +2221,12 @@ class ChooseBrandingForm(StripWhitespaceForm):
class ChooseEmailBrandingForm(ChooseBrandingForm):
def __init__(self, service_id):
ChooseBrandingForm.__init__(self, service_id, branding_type='email')
super().__init__(service_id, branding_type='email')
class ChooseLetterBrandingForm(ChooseBrandingForm):
def __init__(self, service_id):
ChooseBrandingForm.__init__(self, service_id, branding_type='letter')
super().__init__(service_id, branding_type='letter')
class SomethingElseBrandingForm(StripWhitespaceForm):