From f9e2e49dada628bd92698b386bac4d4f001ab276 Mon Sep 17 00:00:00 2001 From: Pete Herlihy Date: Tue, 18 Feb 2020 13:15:57 +0000 Subject: [PATCH] Updating the page title attribute on text message conversations Changing to "Received text message" --- app/templates/views/conversations/conversation.html | 2 +- tests/app/main/views/test_conversation.py | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/app/templates/views/conversations/conversation.html b/app/templates/views/conversations/conversation.html index 5fa5e3f49..a3548e936 100644 --- a/app/templates/views/conversations/conversation.html +++ b/app/templates/views/conversations/conversation.html @@ -3,7 +3,7 @@ {% extends "withnav_template.html" %} {% block service_page_title %} - {{ user_number }} + Received text message {% endblock %} {% block maincolumn_content %} diff --git a/tests/app/main/views/test_conversation.py b/tests/app/main/views/test_conversation.py index aa5eea5f9..bc1090ee5 100644 --- a/tests/app/main/views/test_conversation.py +++ b/tests/app/main/views/test_conversation.py @@ -95,6 +95,14 @@ def test_view_conversation( 'main.conversation', service_id=SERVICE_ONE_ID, notification_id=fake_uuid, + _test_page_title=False, + ) + + assert normalize_spaces(page.select_one('title').text) == ( + 'Received text message – service one – GOV.UK Notify' + ) + assert normalize_spaces(page.select_one('h1').text) == ( + '07123 456789' ) messages = page.select('.sms-message-wrapper') @@ -223,6 +231,7 @@ def test_view_conversation_with_empty_inbound( 'main.conversation', service_id=SERVICE_ONE_ID, notification_id=fake_uuid, + _test_page_title=False, ) messages = page.select('.sms-message-wrapper') @@ -242,6 +251,7 @@ def test_conversation_links_to_reply( 'main.conversation', service_id=SERVICE_ONE_ID, notification_id=fake_uuid, + _test_page_title=False, ) assert page.select('main p')[-1].select_one('a')['href'] == (