diff --git a/app/main/views/service_settings.py b/app/main/views/service_settings.py index a49af5924..746c4de3f 100644 --- a/app/main/views/service_settings.py +++ b/app/main/views/service_settings.py @@ -233,12 +233,10 @@ def service_set_reply_to_email(service_id): if request.method == 'GET': form.email_address.data = current_service.get('reply_to_email_address') if form.validate_on_submit(): - message = 'Reply to email set to {}'.format(form.email_address.data) service_api_client.update_service( current_service['id'], reply_to_email_address=form.email_address.data ) - flash(message, 'default_with_tick') return redirect(url_for('.service_settings', service_id=service_id)) return render_template( 'views/service-settings/set-reply-to-email.html', @@ -253,15 +251,10 @@ def service_set_sms_sender(service_id): if request.method == 'GET': form.sms_sender.data = current_service.get('sms_sender') if form.validate_on_submit(): - if form.sms_sender.data: - message = 'Text message sender set to {}'.format(form.sms_sender.data) - else: - message = 'Text message sender removed' service_api_client.update_service( current_service['id'], sms_sender=form.sms_sender.data or None ) - flash(message, 'default_with_tick') return redirect(url_for('.service_settings', service_id=service_id)) return render_template( 'views/service-settings/set-sms-sender.html', diff --git a/tests/app/main/views/test_service_settings.py b/tests/app/main/views/test_service_settings.py index 919a75c9d..ee81e2d24 100644 --- a/tests/app/main/views/test_service_settings.py +++ b/tests/app/main/views/test_service_settings.py @@ -765,34 +765,6 @@ def test_if_sms_sender_set_then_form_populated(app_, assert page.find(id='sms_sender')['value'] == 'elevenchars' -@pytest.mark.parametrize("sender, expected_flash_message", [ - ("elevenchars", 'Text message sender set to elevenchars'), - ('', 'Text message sender removed') -]) -def test_set_text_message_sender_flash_messages( - app_, - active_user_with_permissions, - mocker, - mock_update_service, - service_one, - sender, - expected_flash_message): - with app_.test_request_context(): - with app_.test_client() as client: - client.login(active_user_with_permissions, mocker, service_one) - data = {"sms_sender": sender} - response = client.post(url_for('main.service_set_sms_sender', service_id=service_one['id']), - data=data, - follow_redirects=True) - - assert response.status_code == 200 - - page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser') - element = page.find('div', {"class": "banner-default-with-tick"}) - - assert element.text.strip() == expected_flash_message - - def test_should_show_branding( mocker, app_, platform_admin_user, service_one, mock_get_organisations ):