mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-08-23 15:57:23 -04:00
Fix wording
Changed forgot-password so that it does not expose to the user that the email address does not exist.
This commit is contained in:
@@ -124,14 +124,6 @@ class AddServiceForm(Form):
|
||||
class ForgotPasswordForm(Form):
|
||||
email_address = email_address()
|
||||
|
||||
def __init__(self, q, *args, **kwargs):
|
||||
self.query_function = q
|
||||
super(ForgotPasswordForm, self).__init__(*args, **kwargs)
|
||||
|
||||
def validate_email_address(self, a):
|
||||
if not self.query_function(a.data):
|
||||
raise ValidationError('The email address is not recognised. Enter the email address you registered with.')
|
||||
|
||||
|
||||
class NewPasswordForm(Form):
|
||||
new_password = password()
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
from flask import render_template, flash
|
||||
from flask import render_template, flash, current_app
|
||||
from app.main import main
|
||||
from app.main.dao import users_dao
|
||||
from app.main.forms import ForgotPasswordForm
|
||||
@@ -7,9 +7,12 @@ from app.main.views import send_change_password_email
|
||||
|
||||
@main.route('/forgot-password', methods=['GET', 'POST'])
|
||||
def forgot_password():
|
||||
form = ForgotPasswordForm(users_dao.get_user_by_email)
|
||||
form = ForgotPasswordForm()
|
||||
if form.validate_on_submit():
|
||||
send_change_password_email(form.email_address.data)
|
||||
return render_template('views/password-reset-sent.html')
|
||||
if users_dao.get_user_by_email(form.email_address.data):
|
||||
send_change_password_email(form.email_address.data)
|
||||
return render_template('views/password-reset-sent.html')
|
||||
else:
|
||||
current_app.logger.info('The email address used does not exist.')
|
||||
else:
|
||||
return render_template('views/forgot-password.html', form=form)
|
||||
|
||||
@@ -10,7 +10,7 @@ from app.main.views import send_sms_code, check_token
|
||||
def new_password(token):
|
||||
email_address = check_token(token)
|
||||
if not email_address:
|
||||
flash('The token we sent you has expired. Enter your email address to try again.')
|
||||
flash('The link in the email we sent you has expired. Enter your email address to resend.')
|
||||
return redirect(url_for('.forgot_password'))
|
||||
|
||||
user = users_dao.get_user_by_email(email_address=email_address.decode('utf-8'))
|
||||
|
||||
@@ -10,7 +10,7 @@ GOV.UK Notify |
|
||||
<div class="column-two-thirds">
|
||||
<h1 class="heading-xlarge">GOV.UK Notify</h1>
|
||||
|
||||
<p>You have been sent an email containing a url to reset your password.</p>
|
||||
<p>You have been sent an email containing a link to reset your password.</p>
|
||||
|
||||
</div>
|
||||
</div>
|
||||
|
||||
Reference in New Issue
Block a user