darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-08 06:28:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

fixing console errors

Browse Source
This commit is contained in:
Beverly Nguyen
2024-08-07 15:42:46 -07:00
parent 5797e989fd
commit f65655e56c
2 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/assets/javascripts/totalMessagesChart.js
View File

@@ -25,7 +25,8 @@
// Ensure the width is set correctly // Ensure the width is set correctly
if (width === 0) { if (width === 0) {
throw new Error('Chart container width is 0, cannot set SVG width.'); console.error('Chart container width is 0, cannot set SVG width.');
return;
} }
svg.attr("width", width).attr("height", height); svg.attr("width", width).attr("height", height);

19
tests/javascripts/totalMessagesChart.test.js
View File

@@ -179,16 +179,17 @@ test('Handles zero width chart container', () => {
// Mock console.error // Mock console.error
const consoleSpy = jest.spyOn(console, 'error').mockImplementation(() => {}); const consoleSpy = jest.spyOn(console, 'error').mockImplementation(() => {});
// Set chart container width to 0 // Set chart container width to 0
Object.defineProperty(document.getElementById('totalMessageChartContainer'), 'clientWidth', { value: 0 }); const chartContainer = document.getElementById('totalMessageChartContainer');
Object.defineProperty(chartContainer, 'clientWidth', { value: 0, configurable: true });
try { // Call the function to create the chart
// Call the function to create the chart window.createTotalMessagesChart();
window.createTotalMessagesChart();
} catch (error) { // Check if the console error was called
// Check if the error message is as expected expect(consoleSpy).toHaveBeenCalledWith('Chart container width is 0, cannot set SVG width.');
expect(error.message).toBe('Chart container width is 0, cannot set SVG width.');
} consoleSpy.mockRestore();
}); });
test('Creates chart on DOMContentLoaded', () => { test('Creates chart on DOMContentLoaded', () => {