diff --git a/tests/app/main/test_permissions.py b/tests/app/main/test_permissions.py index 7244d91bd..9c64f2204 100644 --- a/tests/app/main/test_permissions.py +++ b/tests/app/main/test_permissions.py @@ -5,10 +5,6 @@ import re import pytest from flask import current_app -from app.utils.user_permissions import ( - translate_permissions_from_admin_roles_to_db, - translate_permissions_from_db_to_admin_roles, -) from tests import service_json from tests.conftest import ( ORGANISATION_ID, @@ -18,42 +14,6 @@ from tests.conftest import ( ) -@pytest.mark.parametrize('db_roles,admin_roles', [ - ( - ['approve_broadcasts', 'reject_broadcasts', 'cancel_broadcasts'], - {'approve_broadcasts'}, - ), - ( - ['manage_templates', 'create_broadcasts', 'reject_broadcasts', 'cancel_broadcasts'], - {'create_broadcasts', 'manage_templates'}, - ), - ( - ['manage_templates'], - {'manage_templates'}, - ), - ( - ['create_broadcasts'], - set(), - ), - ( - ['send_texts', 'send_emails', 'send_letters', 'manage_templates', 'some_unknown_permission'], - {'send_messages', 'manage_templates', 'some_unknown_permission'}, - ), -]) -def test_translate_permissions_from_db_to_admin_roles( - db_roles, - admin_roles, -): - roles = translate_permissions_from_db_to_admin_roles(db_roles) - assert roles == admin_roles - - -def test_translate_permissions_from_admin_roles_to_db(): - roles = ['send_messages', 'manage_templates', 'some_unknown_permission'] - db_perms = translate_permissions_from_admin_roles_to_db(roles) - assert db_perms == {'send_texts', 'send_emails', 'send_letters', 'manage_templates', 'some_unknown_permission'} - - @pytest.mark.parametrize( 'user_services, user_organisations, expected_status, organisation_checked', ( diff --git a/tests/app/utils/test_user_permissions.py b/tests/app/utils/test_user_permissions.py new file mode 100644 index 000000000..9ad639022 --- /dev/null +++ b/tests/app/utils/test_user_permissions.py @@ -0,0 +1,42 @@ +import pytest + +from app.utils.user_permissions import ( + translate_permissions_from_admin_roles_to_db, + translate_permissions_from_db_to_admin_roles, +) + + +@pytest.mark.parametrize('db_roles,admin_roles', [ + ( + ['approve_broadcasts', 'reject_broadcasts', 'cancel_broadcasts'], + {'approve_broadcasts'}, + ), + ( + ['manage_templates', 'create_broadcasts', 'reject_broadcasts', 'cancel_broadcasts'], + {'create_broadcasts', 'manage_templates'}, + ), + ( + ['manage_templates'], + {'manage_templates'}, + ), + ( + ['create_broadcasts'], + set(), + ), + ( + ['send_texts', 'send_emails', 'send_letters', 'manage_templates', 'some_unknown_permission'], + {'send_messages', 'manage_templates', 'some_unknown_permission'}, + ), +]) +def test_translate_permissions_from_db_to_admin_roles( + db_roles, + admin_roles, +): + roles = translate_permissions_from_db_to_admin_roles(db_roles) + assert roles == admin_roles + + +def test_translate_permissions_from_admin_roles_to_db(): + roles = ['send_messages', 'manage_templates', 'some_unknown_permission'] + db_perms = translate_permissions_from_admin_roles_to_db(roles) + assert db_perms == {'send_texts', 'send_emails', 'send_letters', 'manage_templates', 'some_unknown_permission'}