diff --git a/tests/app/main/views/test_send.py b/tests/app/main/views/test_send.py index 2767dcf2a..0d9c896e4 100644 --- a/tests/app/main/views/test_send.py +++ b/tests/app/main/views/test_send.py @@ -285,10 +285,10 @@ def test_set_sender_redirects_if_one_sms_sender( @pytest.mark.parametrize( ("sender_data"), [ - (create_multiple_sms_senders()), + (create_multiple_sms_senders(isdefault1=True)), ], ) -def test_usnotify_and_notifygov_removed_if_not_default_sender(sender_data): +def test_usnotify_and_notifygov_sms_sender_removal_not_default(sender_data, mocker): from app.main.views.send import remove_notify_from_sender_options sender_details = remove_notify_from_sender_options(sender_data) @@ -296,6 +296,21 @@ def test_usnotify_and_notifygov_removed_if_not_default_sender(sender_data): assert len(sender_details) == 2 +@pytest.mark.parametrize( + ("sender_data"), + [ + (create_multiple_sms_senders(isdefault1=False, isdefault3=True)), + (create_multiple_sms_senders(isdefault1=False, isdefault4=True)), + ], +) +def test_usnotify_and_notifygov_sms_sender_removal_if_default(sender_data, mocker): + from app.main.views.send import remove_notify_from_sender_options + + sender_details = remove_notify_from_sender_options(sender_data) + + assert len(sender_details) == 3 + + def test_that_test_files_exist(): assert len(test_spreadsheet_files) == 8 assert len(test_non_spreadsheet_files) == 6 diff --git a/tests/conftest.py b/tests/conftest.py index 9691605b7..0c43770d3 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -3452,13 +3452,19 @@ def create_sms_sender( } -def create_multiple_sms_senders(service_id="abcd"): +def create_multiple_sms_senders( + service_id="abcd", + isdefault1=True, + isdefault2=False, + isdefault3=False, + isdefault4=False, +): return [ { "id": "1234", "service_id": service_id, "sms_sender": "Example", - "is_default": True, + "is_default": isdefault1, "created_at": datetime.utcnow(), "inbound_number_id": "1234", "updated_at": None, @@ -3467,7 +3473,7 @@ def create_multiple_sms_senders(service_id="abcd"): "id": "5678", "service_id": service_id, "sms_sender": "Example 2", - "is_default": False, + "is_default": isdefault2, "created_at": datetime.utcnow(), "inbound_number_id": None, "updated_at": None, @@ -3476,7 +3482,7 @@ def create_multiple_sms_senders(service_id="abcd"): "id": "9457", "service_id": service_id, "sms_sender": "US Notify", - "is_default": False, + "is_default": isdefault3, "created_at": datetime.utcnow(), "inbound_number_id": None, "updated_at": None, @@ -3485,7 +3491,7 @@ def create_multiple_sms_senders(service_id="abcd"): "id": "9897", "service_id": service_id, "sms_sender": "Notify.gov", - "is_default": False, + "is_default": isdefault4, "created_at": datetime.utcnow(), "inbound_number_id": None, "updated_at": None,