darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-02-05 19:03:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Refactor live services check

Browse Source 
Changes the check to say ‘does the user have any live services’ rather
than ‘are all their services in trial mode’. The former is closer to
meaning the thing we care about.

Also has the opportunity to short-circuit without having to go through
the full list.
This commit is contained in:
Chris Hill-Scott
2018-12-13 10:37:44 +00:00
parent 688bdd1d7a
commit f44ff0bfc9
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/notify_client/user_api_client.py
View File

@@ -220,8 +220,8 @@ class UserApiClient(NotifyAdminAPIClient):
return sorted(all_services, key=lambda service: service['name'])
def user_has_live_services(self, user):
return not all(
service['restricted'] for service in self.get_services_for_user(user)
return any(
not service['restricted'] for service in self.get_services_for_user(user)
)
def get_service_ids_for_user(self, user):