Use client and logged_in_client fixtures

Wherever possible, because Don’t Repeat Yourself.

tests/app/main/test_create_api_key_form.py

@@ -5,16 +5,15 @@ from werkzeug.datastructures import MultiDict
 from app.main.forms import CreateKeyForm
 
 
-def test_return_validation_error_when_key_name_exists(app_):
+def test_return_validation_error_when_key_name_exists(client):
     def _get_names():
         return ['some key', 'another key']
 
-    with app_.test_request_context():
-        form = CreateKeyForm(_get_names(),
-                             formdata=MultiDict([('key_name', 'Some key')]))
-        form.key_type.choices = [('a', 'a'), ('b', 'b')]
-        form.validate()
-        assert form.errors['key_name'] == ['A key with this name already exists']
+    form = CreateKeyForm(_get_names(),
+                         formdata=MultiDict([('key_name', 'Some key')]))
+    form.key_type.choices = [('a', 'a'), ('b', 'b')]
+    form.validate()
+    assert form.errors['key_name'] == ['A key with this name already exists']
 
 
 @pytest.mark.parametrize(
@@ -23,12 +22,11 @@ def test_return_validation_error_when_key_name_exists(app_):
         ('invalid', 'Not a valid choice')
     ]
 )
-def test_return_validation_error_when_key_type_not_chosen(app_, key_type, expected_error):
+def test_return_validation_error_when_key_type_not_chosen(client, key_type, expected_error):
 
-    with app_.test_request_context():
-        form = CreateKeyForm(
-            [],
-            formdata=MultiDict([('key_name', 'Some key'), ('key_type', key_type)]))
-        form.key_type.choices = [('a', 'a'), ('b', 'b')]
-        form.validate()
-        assert form.errors['key_type'] == [expected_error]
+    form = CreateKeyForm(
+        [],
+        formdata=MultiDict([('key_name', 'Some key'), ('key_type', key_type)]))
+    form.key_type.choices = [('a', 'a'), ('b', 'b')]
+    form.validate()
+    assert form.errors['key_type'] == [expected_error]