Enforce order and style of imports

Done using isort[1], with the following command:
```
isort -rc ./app ./tests
```

Adds linting to the `run_tests.sh` script to stop badly-sorted imports
getting re-introduced.

Chosen style is ‘Vertical Hanging Indent’ with trailing commas, because
I think it gives the cleanest diffs, eg:
```
from third_party import (
    lib1,
    lib2,
    lib3,
    lib4,
)
```

1. https://pypi.python.org/pypi/isort
This commit is contained in:
Chris Hill-Scott
2018-02-20 11:22:17 +00:00
parent 0217a6a962
commit f3a0c505bd
102 changed files with 622 additions and 647 deletions

View File

@@ -1,17 +1,24 @@
from bs4 import BeautifulSoup, element
from functools import partial
import pytest
from flask import url_for
from werkzeug.exceptions import InternalServerError
from unittest.mock import ANY
import pytest
from bs4 import BeautifulSoup, element
from flask import url_for
from freezegun import freeze_time
from notifications_utils.clients import DeskproError
from tests.conftest import (
mock_get_services,
mock_get_services_with_no_services,
mock_get_services_with_one_service
mock_get_services_with_one_service,
)
from werkzeug.exceptions import InternalServerError
from app.main.views.feedback import (
PROBLEM_TICKET_TYPE,
QUESTION_TICKET_TYPE,
has_live_services,
in_business_hours,
)
from app.main.views.feedback import has_live_services, in_business_hours, PROBLEM_TICKET_TYPE, QUESTION_TICKET_TYPE
def no_redirect():