darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-04 05:31:44 -04:00
Code Issues Packages Projects Releases Wiki Activity

Enforce order and style of imports

Browse Source 
Done using isort[1], with the following command:
```
isort -rc ./app ./tests
```

Adds linting to the `run_tests.sh` script to stop badly-sorted imports
getting re-introduced.

Chosen style is ‘Vertical Hanging Indent’ with trailing commas, because
I think it gives the cleanest diffs, eg:
```
from third_party import (
    lib1,
    lib2,
    lib3,
    lib4,
)
```

1. https://pypi.python.org/pypi/isort
This commit is contained in:
Chris Hill-Scott
2018-02-20 11:22:17 +00:00
parent 0217a6a962
commit f3a0c505bd
102 changed files with 622 additions and 647 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/notify_client/api_key_api_client.py
View File

@@ -1,4 +1,4 @@
from app.notify_client import _attach_current_user, NotifyAdminAPIClient
from app.notify_client import NotifyAdminAPIClient, _attach_current_user
# must match key types in notifications-api/app/models.py
KEY_TYPE_NORMAL = 'normal'

2
app/notify_client/invite_api_client.py
View File

@@ -1,5 +1,5 @@
from app.notify_client import _attach_current_user, NotifyAdminAPIClient
from app.notify_client import NotifyAdminAPIClient, _attach_current_user
from app.notify_client.models import InvitedUser

2
app/notify_client/job_api_client.py
View File

@@ -1,6 +1,6 @@
from collections import defaultdict
from app.notify_client import _attach_current_user, NotifyAdminAPIClient
from app.notify_client import NotifyAdminAPIClient, _attach_current_user
class JobApiClient(NotifyAdminAPIClient):

4
app/notify_client/models.py
View File

@@ -1,7 +1,7 @@
from itertools import chain
from flask_login import UserMixin, AnonymousUserMixin
from flask import request, session
from flask import request, session
from flask_login import AnonymousUserMixin, UserMixin
roles = {
'send_messages': ['send_texts', 'send_emails', 'send_letters'],

2
app/notify_client/notification_api_client.py
View File

@@ -1,4 +1,4 @@
from app.notify_client import _attach_current_user, NotifyAdminAPIClient
from app.notify_client import NotifyAdminAPIClient, _attach_current_user
class NotificationApiClient(NotifyAdminAPIClient):

2
app/notify_client/org_invite_api_client.py
View File

@@ -1,4 +1,4 @@
from app.notify_client import _attach_current_user, NotifyAdminAPIClient
from app.notify_client import NotifyAdminAPIClient, _attach_current_user
from app.notify_client.models import InvitedOrgUser

2
app/notify_client/organisations_api_client.py
View File

@@ -1,4 +1,4 @@
from app.notify_client import _attach_current_user, NotifyAdminAPIClient
from app.notify_client import NotifyAdminAPIClient, _attach_current_user
class OrganisationsClient(NotifyAdminAPIClient):

2
app/notify_client/provider_client.py
View File

@@ -1,5 +1,5 @@
from app.notify_client import _attach_current_user, NotifyAdminAPIClient
from app.notify_client import NotifyAdminAPIClient, _attach_current_user
class ProviderClient(NotifyAdminAPIClient):

3
app/notify_client/service_api_client.py
View File

@@ -1,8 +1,9 @@
from __future__ import unicode_literals
from flask import url_for
from app.notify_client import NotifyAdminAPIClient, _attach_current_user
from app.utils import BrowsableItem
from app.notify_client import _attach_current_user, NotifyAdminAPIClient
class ServiceAPIClient(NotifyAdminAPIClient):