darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-18 21:49:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2268 from alphagov/request-to-go-live-better-data

Browse Source 
Make the data we get from the go live requests more useful
This commit is contained in:
Chris Hill-Scott
2018-09-04 16:25:59 +01:00
committed by GitHub
parent b8eb7c324c 3c563ddca6
commit f387f1e6ba
6 changed files with 99 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files

63
tests/app/main/views/test_service_settings.py
View File

@@ -691,23 +691,25 @@ def test_should_show_request_to_go_live(
)
assert page.h1.text == 'Request to go live'
for channel, label in (
('email', 'Emails'),
('sms', 'Text messages'),
('letter', 'Letters'),
(
'email',
'How many emails do you expect to send in the next year? For example, 1,000,000'
),
(
'sms',
'How many text messages do you expect to send in the next year? For example, 500,000'
),
(
'letter',
'How many letters do you expect to send in the next year? For example, 5,000'
),
):
assert normalize_spaces(
page.select_one('label[for=channel_{}]'.format(channel)).text
) == label
for feature, label in (
('one_off', 'One at a time'),
('upload', 'Upload a spreadsheet of recipients'),
('api', 'Integrate with the GOV.UK Notify API'),
):
assert normalize_spaces(
page.select_one('label[for=method_{}]'.format(feature)).text
page.select_one('label[for=volume_{}]'.format(channel)).text
) == label
@freeze_time("2012-12-21")
def test_should_redirect_after_request_to_go_live(
client_request,
mocker,
@@ -723,14 +725,10 @@ def test_should_redirect_after_request_to_go_live(
'main.submit_request_to_go_live',
service_id=SERVICE_ONE_ID,
_data={
'channel_email': 'y',
'channel_sms': 'y',
'start_date': '01/01/2017',
'start_volume': '100,000',
'peak_volume': '2,000,000',
'method_one_off': 'y',
'method_upload': 'y',
'method_api': 'y',
'volume_email': '111',
'volume_sms': '222',
'volume_letter': '333',
'research_consent': 'yes',
},
_follow_redirects=True
)
@@ -741,16 +739,21 @@ def test_should_redirect_after_request_to_go_live(
user_name=active_user_with_permissions.name,
user_email=active_user_with_permissions.email_address
)
returned_message = mock_post.call_args[1]['message']
assert 'Service: service one' in returned_message
assert 'Organisation type: central' in returned_message
assert 'Agreement signed: Can’t tell' in returned_message
assert 'Channel: email and text messages' in returned_message
assert 'Start date: 01/01/2017' in returned_message
assert 'Start volume: 100,000' in returned_message
assert 'Peak volume: 2,000,000' in returned_message
assert 'Features: one off, file upload and API' in returned_message
assert mock_post.call_args[1]['message'] == (
'Service: service one\n'
'http://localhost/services/{}\n'
'\n'
'---\n'
'Organisation type: Central\n'
'Agreement signed: Can’t tell (domain is user.gov.uk)\n'
'Emails in next year: 111\n'
'Text messages in next year: 222\n'
'Letters in next year: 333\n'
'Consent to research: Yes\n'
'\n'
'---\n'
'{}, None, service one, Test User, test@user.gov.uk, -, 21/12/2012, 222, 111, 333'
).format(SERVICE_ONE_ID, SERVICE_ONE_ID)
assert normalize_spaces(page.select_one('.banner-default').text) == (
'Thanks for your request to go live. We’ll get back to you within one working day.'