darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-02 17:48:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refactor to split s3_client.py into multiple files

Browse Source 
Separated s3_client.py into 3 files - for logos, CSV files and the MOU.
This helps to keep things clearer now that we need to add lots more logo
functions for letters.
This commit is contained in:
Katie Smith
2019-01-30 09:42:15 +00:00
parent 5e6d48e50f
commit f005d7a569
15 changed files with 202 additions and 185 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/app/main/views/test_agreement.py
View File

@@ -78,7 +78,7 @@ def test_downloading_agreement(
expected_file_served,
):
mock_get_s3_object = mocker.patch(
'app.main.s3_client.get_s3_object',
'app.s3_client.s3_mou_client.get_s3_object',
return_value=_MockS3Object(b'foo')
)
user = active_user_with_permissions(fake_uuid)
@@ -100,7 +100,7 @@ def test_agreement_cant_be_downloaded_unknown_crown_status(
fake_uuid,
):
mock_get_s3_object = mocker.patch(
'app.main.s3_client.get_s3_object',
'app.s3_client.s3_mou_client.get_s3_object',
return_value=_MockS3Object()
)
user = active_user_with_permissions(fake_uuid)
@@ -116,7 +116,7 @@ def test_agreement_requires_login(
mocker,
):
mock_get_s3_object = mocker.patch(
'app.main.s3_client.get_s3_object',
'app.s3_client.s3_mou_client.get_s3_object',
return_value=_MockS3Object()
)
response = client.get(url_for('main.download_agreement'))
@@ -142,7 +142,7 @@ def test_show_public_agreement_page(
expected_status,
):
mocker.patch(
'app.main.s3_client.get_s3_object',
'app.s3_client.s3_mou_client.get_s3_object',
return_value=_MockS3Object()
)
response = client.get(url_for(