From ef79edba094a01320777c14037e2aef121f80ddc Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Tue, 18 May 2021 15:16:15 +0100 Subject: [PATCH] Remove uneccessary parametrize It proves the behaviour isn't dependent on the channel, but there are other variables we could equally prove that for, which we're not testing here. --- tests/app/main/views/test_broadcast.py | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/tests/app/main/views/test_broadcast.py b/tests/app/main/views/test_broadcast.py index 200009864..518a24ed2 100644 --- a/tests/app/main/views/test_broadcast.py +++ b/tests/app/main/views/test_broadcast.py @@ -1926,11 +1926,6 @@ def test_confirm_approve_non_training_broadcasts( ) -@pytest.mark.parametrize('channel', ( - 'test', - 'severe', - 'government', -)) @freeze_time('2020-02-22T22:22:22.000000') def test_confirm_approve_non_training_broadcasts_errors_if_not_ticked( mocker, @@ -1940,7 +1935,6 @@ def test_confirm_approve_non_training_broadcasts_errors_if_not_ticked( fake_uuid, mock_update_broadcast_message, mock_update_broadcast_message_status, - channel, ): mocker.patch( 'app.broadcast_message_api_client.get_broadcast_message', @@ -1955,7 +1949,7 @@ def test_confirm_approve_non_training_broadcasts_errors_if_not_ticked( service_one['permissions'] += ['broadcast'] service_one['restricted'] = False service_one['allowed_broadcast_provider'] = 'all' - service_one['broadcast_channel'] = channel + service_one['broadcast_channel'] = 'severe' page = client_request.post( '.view_current_broadcast',