From ef4dd9d12680368d2abf4354e59e8a9703d9c0a1 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Mon, 30 Apr 2018 11:31:50 +0100 Subject: [PATCH] Add some breathing room to file name length limit Because Amazon stores metadata keys prefixed with `x-amz-` which might get counted as part of the size. --- app/main/views/send.py | 2 +- tests/app/main/views/test_send.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/main/views/send.py b/app/main/views/send.py index 954a3a1cb..21f09d657 100644 --- a/app/main/views/send.py +++ b/app/main/views/send.py @@ -558,7 +558,7 @@ def _check_messages(service_id, template_id, upload_id, preview_row, letters_as_ valid=True, original_file_name=unicode_truncate( request.args.get('original_file_name', ''), - 1872 + 1600, ), ) else: diff --git a/tests/app/main/views/test_send.py b/tests/app/main/views/test_send.py index 21abc0958..b9fb71350 100644 --- a/tests/app/main/views/test_send.py +++ b/tests/app/main/views/test_send.py @@ -700,7 +700,7 @@ def test_file_name_truncated_to_fit_in_s3_metadata( assert sys.getsizeof(''.join(( '{}{}'.format(key, value) for key, value in mock_s3_set_metadata.call_args_list[0][1].items() - )).encode('utf-8')) == 1998 + )).encode('utf-8')) == 1724 def test_show_all_columns_if_there_are_duplicate_recipient_columns(