Require IDs to be UUIDs in URLS

We mostly rely on the API returning a 404 to generate 404s for trying
to get things with non-UUID IDs. This is fine, except our tests often
mock these API calls. So it could look like everything is working fine,
except the thing your passing in might never be a valid UUID, and thus
would 404 in a non-test environment.

So this commit:
1. uses the `uuid` URL converter everywhere there’s something that looks
   like an ID in a URL parameter
2.  adds a test which automates checking for 1.

app/main/views/service_settings.py

@@ -71,7 +71,7 @@ PLATFORM_ADMIN_SERVICE_PERMISSIONS = OrderedDict([
 ])
 
 
-@main.route("/services/<service_id>/service-settings")
+@main.route("/services/<uuid:service_id>/service-settings")
 @user_has_permissions('manage_service', 'manage_api_keys')
 def service_settings(service_id):
     return render_template(
@@ -80,7 +80,7 @@ def service_settings(service_id):
     )
 
 
-@main.route("/services/<service_id>/service-settings/name", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/service-settings/name", methods=['GET', 'POST'])
 @user_has_permissions('manage_service')
 def service_name_change(service_id):
     form = RenameServiceForm()
@@ -108,7 +108,7 @@ def service_name_change(service_id):
     )
 
 
-@main.route("/services/<service_id>/service-settings/name/confirm", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/service-settings/name/confirm", methods=['GET', 'POST'])
 @user_has_permissions('manage_service')
 def service_name_change_confirm(service_id):
     # Validate password for form
@@ -140,7 +140,7 @@ def service_name_change_confirm(service_id):
         form=form)
 
 
-@main.route("/services/<service_id>/service-settings/request-to-go-live/estimate-usage", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/service-settings/request-to-go-live/estimate-usage", methods=['GET', 'POST'])
 @user_has_permissions('manage_service')
 def estimate_usage(service_id):
 
@@ -172,7 +172,7 @@ def estimate_usage(service_id):
     )
 
 
-@main.route("/services/<service_id>/service-settings/request-to-go-live", methods=['GET'])
+@main.route("/services/<uuid:service_id>/service-settings/request-to-go-live", methods=['GET'])
 @user_has_permissions('manage_service')
 def request_to_go_live(service_id):
     return render_template(
@@ -180,7 +180,7 @@ def request_to_go_live(service_id):
     )
 
 
-@main.route("/services/<service_id>/service-settings/request-to-go-live", methods=['POST'])
+@main.route("/services/<uuid:service_id>/service-settings/request-to-go-live", methods=['POST'])
 @user_has_permissions('manage_service')
 @user_is_gov_user
 def submit_request_to_go_live(service_id):
@@ -228,7 +228,7 @@ def submit_request_to_go_live(service_id):
     return redirect(url_for('.service_settings', service_id=service_id))
 
 
-@main.route("/services/<service_id>/service-settings/switch-live", methods=["GET", "POST"])
+@main.route("/services/<uuid:service_id>/service-settings/switch-live", methods=["GET", "POST"])
 @user_is_platform_admin
 def service_switch_live(service_id):
     form = ServiceOnOffSettingForm(
@@ -247,7 +247,7 @@ def service_switch_live(service_id):
     )
 
 
-@main.route("/services/<service_id>/service-settings/switch-count-as-live", methods=["GET", "POST"])
+@main.route("/services/<uuid:service_id>/service-settings/switch-count-as-live", methods=["GET", "POST"])
 @user_is_platform_admin
 def service_switch_count_as_live(service_id):
 
@@ -269,7 +269,7 @@ def service_switch_count_as_live(service_id):
     )
 
 
-@main.route("/services/<service_id>/service-settings/permissions/<permission>", methods=["GET", "POST"])
+@main.route("/services/<uuid:service_id>/service-settings/permissions/<permission>", methods=["GET", "POST"])
 @user_is_platform_admin
 def service_set_permission(service_id, permission):
     if permission not in PLATFORM_ADMIN_SERVICE_PERMISSIONS:
@@ -293,7 +293,7 @@ def service_set_permission(service_id, permission):
     )
 
 
-@main.route("/services/<service_id>/service-settings/can-upload-document", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/service-settings/can-upload-document", methods=['GET', 'POST'])
 @user_is_platform_admin
 def service_switch_can_upload_document(service_id):
     if current_service.contact_link:
@@ -313,7 +313,7 @@ def service_switch_can_upload_document(service_id):
     return render_template('views/service-settings/contact_link.html', form=form)
 
 
-@main.route("/services/<service_id>/service-settings/archive", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/service-settings/archive", methods=['GET', 'POST'])
 @user_has_permissions('manage_service')
 def archive_service(service_id):
     if not current_service.active and (
@@ -335,7 +335,7 @@ def archive_service(service_id):
         return service_settings(service_id)
 
 
-@main.route("/services/<service_id>/service-settings/suspend", methods=["GET", "POST"])
+@main.route("/services/<uuid:service_id>/service-settings/suspend", methods=["GET", "POST"])
 @user_has_permissions('manage_service')
 def suspend_service(service_id):
     if request.method == 'POST':
@@ -347,7 +347,7 @@ def suspend_service(service_id):
         return service_settings(service_id)
 
 
-@main.route("/services/<service_id>/service-settings/resume", methods=["GET", "POST"])
+@main.route("/services/<uuid:service_id>/service-settings/resume", methods=["GET", "POST"])
 @user_has_permissions('manage_service')
 def resume_service(service_id):
     if request.method == 'POST':
@@ -358,7 +358,7 @@ def resume_service(service_id):
         return service_settings(service_id)
 
 
-@main.route("/services/<service_id>/service-settings/contact-link", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/service-settings/contact-link", methods=['GET', 'POST'])
 @user_has_permissions('manage_service')
 def service_set_contact_link(service_id):
     form = ServiceContactDetailsForm()
@@ -382,19 +382,19 @@ def service_set_contact_link(service_id):
     return render_template('views/service-settings/contact_link.html', form=form)
 
 
-@main.route("/services/<service_id>/service-settings/set-reply-to-email", methods=['GET'])
+@main.route("/services/<uuid:service_id>/service-settings/set-reply-to-email", methods=['GET'])
 @user_has_permissions('manage_service')
 def service_set_reply_to_email(service_id):
     return redirect(url_for('.service_email_reply_to', service_id=service_id))
 
 
-@main.route("/services/<service_id>/service-settings/email-reply-to", methods=['GET'])
+@main.route("/services/<uuid:service_id>/service-settings/email-reply-to", methods=['GET'])
 @user_has_permissions('manage_service', 'manage_api_keys')
 def service_email_reply_to(service_id):
     return render_template('views/service-settings/email_reply_to.html')
 
 
-@main.route("/services/<service_id>/service-settings/email-reply-to/add", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/service-settings/email-reply-to/add", methods=['GET', 'POST'])
 @user_has_permissions('manage_service')
 def service_add_email_reply_to(service_id):
     form = ServiceReplyToEmailForm()
@@ -425,7 +425,7 @@ def service_add_email_reply_to(service_id):
         first_email_address=first_email_address)
 
 
-@main.route("/services/<service_id>/service-settings/email-reply-to/<notification_id>/verify", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/service-settings/email-reply-to/<uuid:notification_id>/verify", methods=['GET', 'POST'])
 @user_has_permissions('manage_service')
 def service_verify_reply_to_address(service_id, notification_id):
     replace = request.args.get('replace', False)
@@ -441,7 +441,7 @@ def service_verify_reply_to_address(service_id, notification_id):
     )
 
 
-@main.route("/services/<service_id>/service-settings/email-reply-to/<notification_id>/verify.json")
+@main.route("/services/<uuid:service_id>/service-settings/email-reply-to/<uuid:notification_id>/verify.json")
 @user_has_permissions('manage_service')
 def service_verify_reply_to_address_updates(service_id, notification_id):
     return jsonify(**get_service_verify_reply_to_address_partials(service_id, notification_id))
@@ -498,12 +498,12 @@ def get_service_verify_reply_to_address_partials(service_id, notification_id):
 
 
 @main.route(
-    "/services/<service_id>/service-settings/email-reply-to/<reply_to_email_id>/edit",
+    "/services/<uuid:service_id>/service-settings/email-reply-to/<uuid:reply_to_email_id>/edit",
     methods=['GET', 'POST'],
     endpoint="service_edit_email_reply_to"
 )
 @main.route(
-    "/services/<service_id>/service-settings/email-reply-to/<reply_to_email_id>/delete",
+    "/services/<uuid:service_id>/service-settings/email-reply-to/<uuid:reply_to_email_id>/delete",
     methods=['GET'],
     endpoint="service_confirm_delete_email_reply_to"
 )
@@ -551,7 +551,10 @@ def service_edit_email_reply_to(service_id, reply_to_email_id):
     )
 
 
-@main.route("/services/<service_id>/service-settings/email-reply-to/<reply_to_email_id>/delete", methods=['POST'])
+@main.route(
+    "/services/<uuid:service_id>/service-settings/email-reply-to/<uuid:reply_to_email_id>/delete",
+    methods=['POST']
+)
 @user_has_permissions('manage_service')
 def service_delete_email_reply_to(service_id, reply_to_email_id):
     service_api_client.delete_reply_to_email_address(
@@ -561,7 +564,7 @@ def service_delete_email_reply_to(service_id, reply_to_email_id):
     return redirect(url_for('.service_email_reply_to', service_id=service_id))
 
 
-@main.route("/services/<service_id>/service-settings/set-inbound-number", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/service-settings/set-inbound-number", methods=['GET', 'POST'])
 @user_has_permissions('manage_service')
 def service_set_inbound_number(service_id):
     available_inbound_numbers = inbound_number_client.get_available_inbound_sms_numbers()
@@ -590,7 +593,7 @@ def service_set_inbound_number(service_id):
     )
 
 
-@main.route("/services/<service_id>/service-settings/sms-prefix", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/service-settings/sms-prefix", methods=['GET', 'POST'])
 @user_has_permissions('manage_service')
 def service_set_sms_prefix(service_id):
 
@@ -612,7 +615,7 @@ def service_set_sms_prefix(service_id):
     )
 
 
-@main.route("/services/<service_id>/service-settings/set-international-sms", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/service-settings/set-international-sms", methods=['GET', 'POST'])
 @user_has_permissions('manage_service')
 def service_set_international_sms(service_id):
     form = InternationalSMSForm(
@@ -632,7 +635,7 @@ def service_set_international_sms(service_id):
     )
 
 
-@main.route("/services/<service_id>/service-settings/set-inbound-sms", methods=['GET'])
+@main.route("/services/<uuid:service_id>/service-settings/set-inbound-sms", methods=['GET'])
 @user_has_permissions('manage_service')
 def service_set_inbound_sms(service_id):
     return render_template(
@@ -640,7 +643,7 @@ def service_set_inbound_sms(service_id):
     )
 
 
-@main.route("/services/<service_id>/service-settings/set-letters", methods=['GET'])
+@main.route("/services/<uuid:service_id>/service-settings/set-letters", methods=['GET'])
 @user_has_permissions('manage_service')
 def service_set_letters(service_id):
     return redirect(
@@ -653,7 +656,7 @@ def service_set_letters(service_id):
     )
 
 
-@main.route("/services/<service_id>/service-settings/set-<channel>", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/service-settings/set-<channel>", methods=['GET', 'POST'])
 @user_has_permissions('manage_service')
 def service_set_channel(service_id, channel):
 
@@ -680,7 +683,7 @@ def service_set_channel(service_id, channel):
     )
 
 
-@main.route("/services/<service_id>/service-settings/set-auth-type", methods=['GET'])
+@main.route("/services/<uuid:service_id>/service-settings/set-auth-type", methods=['GET'])
 @user_has_permissions('manage_service')
 def service_set_auth_type(service_id):
     return render_template(
@@ -688,7 +691,7 @@ def service_set_auth_type(service_id):
     )
 
 
-@main.route("/services/<service_id>/service-settings/letter-contacts", methods=['GET'])
+@main.route("/services/<uuid:service_id>/service-settings/letter-contacts", methods=['GET'])
 @user_has_permissions('manage_service', 'manage_api_keys')
 def service_letter_contact_details(service_id):
     letter_contact_details = service_api_client.get_letter_contacts(service_id)
@@ -697,7 +700,7 @@ def service_letter_contact_details(service_id):
         letter_contact_details=letter_contact_details)
 
 
-@main.route("/services/<service_id>/service-settings/letter-contact/add", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/service-settings/letter-contact/add", methods=['GET', 'POST'])
 @user_has_permissions('manage_service')
 def service_add_letter_contact(service_id):
     form = ServiceLetterContactBlockForm()
@@ -732,12 +735,12 @@ def service_add_letter_contact(service_id):
 
 
 @main.route(
-    "/services/<service_id>/service-settings/letter-contact/<letter_contact_id>/edit",
+    "/services/<uuid:service_id>/service-settings/letter-contact/<uuid:letter_contact_id>/edit",
     methods=['GET', 'POST'],
     endpoint="service_edit_letter_contact",
 )
 @main.route(
-    "/services/<service_id>/service-settings/letter-contact/<letter_contact_id>/delete",
+    "/services/<uuid:service_id>/service-settings/letter-contact/<uuid:letter_contact_id>/delete",
     methods=['GET'],
     endpoint="service_confirm_delete_letter_contact",
 )
@@ -765,7 +768,7 @@ def service_edit_letter_contact(service_id, letter_contact_id):
         letter_contact_id=letter_contact_block['id'])
 
 
-@main.route("/services/<service_id>/service-settings/letter-contact/make-blank-default")
+@main.route("/services/<uuid:service_id>/service-settings/letter-contact/make-blank-default")
 @user_has_permissions('manage_service')
 def service_make_blank_default_letter_contact(service_id):
     current_service.remove_default_letter_contact_block()
@@ -773,7 +776,7 @@ def service_make_blank_default_letter_contact(service_id):
 
 
 @main.route(
-    "/services/<service_id>/service-settings/letter-contact/<letter_contact_id>/delete",
+    "/services/<uuid:service_id>/service-settings/letter-contact/<uuid:letter_contact_id>/delete",
     methods=['POST'],
 )
 @user_has_permissions('manage_service')
@@ -785,7 +788,7 @@ def service_delete_letter_contact(service_id, letter_contact_id):
     return redirect(url_for('.service_letter_contact_details', service_id=current_service.id))
 
 
-@main.route("/services/<service_id>/service-settings/sms-sender", methods=['GET'])
+@main.route("/services/<uuid:service_id>/service-settings/sms-sender", methods=['GET'])
 @user_has_permissions('manage_service', 'manage_api_keys')
 def service_sms_senders(service_id):
     return render_template(
@@ -793,7 +796,7 @@ def service_sms_senders(service_id):
     )
 
 
-@main.route("/services/<service_id>/service-settings/sms-sender/add", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/service-settings/sms-sender/add", methods=['GET', 'POST'])
 @user_has_permissions('manage_service')
 def service_add_sms_sender(service_id):
     form = ServiceSmsSenderForm()
@@ -812,12 +815,12 @@ def service_add_sms_sender(service_id):
 
 
 @main.route(
-    "/services/<service_id>/service-settings/sms-sender/<sms_sender_id>/edit",
+    "/services/<uuid:service_id>/service-settings/sms-sender/<uuid:sms_sender_id>/edit",
     methods=['GET', 'POST'],
     endpoint="service_edit_sms_sender"
 )
 @main.route(
-    "/services/<service_id>/service-settings/sms-sender/<sms_sender_id>/delete",
+    "/services/<uuid:service_id>/service-settings/sms-sender/<uuid:sms_sender_id>/delete",
     methods=['GET'],
     endpoint="service_confirm_delete_sms_sender"
 )
@@ -852,7 +855,7 @@ def service_edit_sms_sender(service_id, sms_sender_id):
 
 
 @main.route(
-    "/services/<service_id>/service-settings/sms-sender/<sms_sender_id>/delete",
+    "/services/<uuid:service_id>/service-settings/sms-sender/<uuid:sms_sender_id>/delete",
     methods=['POST'],
 )
 @user_has_permissions('manage_service')
@@ -864,7 +867,7 @@ def service_delete_sms_sender(service_id, sms_sender_id):
     return redirect(url_for('.service_sms_senders', service_id=service_id))
 
 
-@main.route("/services/<service_id>/service-settings/set-letter-contact-block", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/service-settings/set-letter-contact-block", methods=['GET', 'POST'])
 @user_has_permissions('manage_service')
 def service_set_letter_contact_block(service_id):
 
@@ -887,7 +890,7 @@ def service_set_letter_contact_block(service_id):
     )
 
 
-@main.route("/services/<service_id>/service-settings/set-free-sms-allowance", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/service-settings/set-free-sms-allowance", methods=['GET', 'POST'])
 @user_is_platform_admin
 def set_free_sms_allowance(service_id):
 
@@ -904,7 +907,7 @@ def set_free_sms_allowance(service_id):
     )
 
 
-@main.route("/services/<service_id>/service-settings/set-email-branding", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/service-settings/set-email-branding", methods=['GET', 'POST'])
 @user_is_platform_admin
 def service_set_email_branding(service_id):
     email_branding = email_branding_client.get_all_email_branding()
@@ -928,7 +931,7 @@ def service_set_email_branding(service_id):
     )
 
 
-@main.route("/services/<service_id>/service-settings/preview-email-branding", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/service-settings/preview-email-branding", methods=['GET', 'POST'])
 @user_is_platform_admin
 def service_preview_email_branding(service_id):
     branding_style = request.args.get('branding_style', None)
@@ -949,7 +952,7 @@ def service_preview_email_branding(service_id):
     )
 
 
-@main.route("/services/<service_id>/service-settings/set-letter-branding", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/service-settings/set-letter-branding", methods=['GET', 'POST'])
 @user_is_platform_admin
 def service_set_letter_branding(service_id):
     letter_branding = letter_branding_client.get_all_letter_branding()
@@ -973,7 +976,7 @@ def service_set_letter_branding(service_id):
     )
 
 
-@main.route("/services/<service_id>/service-settings/preview-letter-branding", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/service-settings/preview-letter-branding", methods=['GET', 'POST'])
 @user_is_platform_admin
 def service_preview_letter_branding(service_id):
     branding_style = request.args.get('branding_style')
@@ -994,7 +997,7 @@ def service_preview_letter_branding(service_id):
     )
 
 
-@main.route("/services/<service_id>/service-settings/request-letter-branding", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/service-settings/request-letter-branding", methods=['GET', 'POST'])
 @user_has_permissions('manage_service', 'manage_templates')
 def request_letter_branding(service_id):
     return render_template(
@@ -1003,7 +1006,7 @@ def request_letter_branding(service_id):
     )
 
 
-@main.route("/services/<service_id>/service-settings/link-service-to-organisation", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/service-settings/link-service-to-organisation", methods=['GET', 'POST'])
 @user_is_platform_admin
 def link_service_to_organisation(service_id):
 
@@ -1031,7 +1034,7 @@ def link_service_to_organisation(service_id):
     )
 
 
-@main.route("/services/<service_id>/branding-request/email", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/branding-request/email", methods=['GET', 'POST'])
 @user_has_permissions('manage_service')
 def branding_request(service_id):
 
@@ -1077,7 +1080,7 @@ def branding_request(service_id):
     )
 
 
-@main.route("/services/<service_id>/data-retention", methods=['GET'])
+@main.route("/services/<uuid:service_id>/data-retention", methods=['GET'])
 @user_is_platform_admin
 def data_retention(service_id):
     return render_template(
@@ -1085,7 +1088,7 @@ def data_retention(service_id):
     )
 
 
-@main.route("/services/<service_id>/data-retention/add", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/data-retention/add", methods=['GET', 'POST'])
 @user_is_platform_admin
 def add_data_retention(service_id):
     form = ServiceDataRetentionForm()
@@ -1100,7 +1103,7 @@ def add_data_retention(service_id):
     )
 
 
-@main.route("/services/<service_id>/data-retention/<data_retention_id>/edit", methods=['GET', 'POST'])
+@main.route("/services/<uuid:service_id>/data-retention/<uuid:data_retention_id>/edit", methods=['GET', 'POST'])
 @user_is_platform_admin
 def edit_data_retention(service_id, data_retention_id):
     data_retention_item = current_service.get_data_retention_item(data_retention_id)