From 9523e224bcaa6a65676b7ae8b4bc5cd4d15453cf Mon Sep 17 00:00:00 2001 From: Adam Shimali Date: Wed, 9 Mar 2016 15:30:40 +0000 Subject: [PATCH] Removed links for deleting users. Also removed view function that allowed deletion of users. --- app/main/views/manage_users.py | 22 ------------------- .../views/edit-user-permissions.html | 16 +++++--------- app/templates/views/invite-user.html | 12 +--------- 3 files changed, 6 insertions(+), 44 deletions(-) diff --git a/app/main/views/manage_users.py b/app/main/views/manage_users.py index 5a0a7f5c9..6848794a5 100644 --- a/app/main/views/manage_users.py +++ b/app/main/views/manage_users.py @@ -103,28 +103,6 @@ def edit_user_permissions(service_id, user_id): ) -@main.route("/services//users//delete", methods=['GET', 'POST']) -@login_required -@user_has_permissions('manage_users', 'manage_templates', 'manage_settings') -def delete_user(service_id, user_id): - user = user_api_client.get_user(user_id) - service = get_service_by_id(service_id) - - if request.method == 'POST': - return redirect(url_for('.manage_users', service_id=service_id)) - - flash( - 'Are you sure you want to delete {}’s account?'.format(user.get('name') or user['email_localpart']), - 'delete' - ) - - return render_template( - 'views/invite-user.html', - user=user, - service_id=service_id - ) - - @main.route("/services//cancel-invited-user/", methods=['GET']) @user_has_permissions('manage_users', 'manage_templates', 'manage_settings') def cancel_invited_user(service_id, invited_user_id): diff --git a/app/templates/views/edit-user-permissions.html b/app/templates/views/edit-user-permissions.html index 291d7fa62..4af2cb2ce 100644 --- a/app/templates/views/edit-user-permissions.html +++ b/app/templates/views/edit-user-permissions.html @@ -26,17 +26,11 @@ Manage users – GOV.UK Notify {{ yes_no(form.manage_api_keys.name, form.manage_api_keys.label, form.manage_api_keys.data) }} - {% if user %} - {{ page_footer( - 'Save', - delete_link=url_for('.delete_user', service_id=service_id, user_id=user_id), - delete_link_text='Delete this account', - back_link=url_for('.manage_users', service_id=service_id), - back_link_text='Cancel' - ) }} - {% else %} - {{ page_footer('Send invitation email') }} - {% endif %} + {{ page_footer( + 'Save', + back_link=url_for('.manage_users', service_id=service_id), + back_link_text='Cancel' + ) }} diff --git a/app/templates/views/invite-user.html b/app/templates/views/invite-user.html index 407c2693f..dda36ff8c 100644 --- a/app/templates/views/invite-user.html +++ b/app/templates/views/invite-user.html @@ -28,17 +28,7 @@ Manage users – GOV.UK Notify {{ yes_no(form.manage_api_keys.name, form.manage_api_keys.label, form.manage_api_keys.data) }} - {% if user %} - {{ page_footer( - 'Save', - delete_link=url_for('.delete_user', service_id=service_id, user_id=user_id), - delete_link_text='Delete this account', - back_link=url_for('.manage_users', service_id=service_id), - back_link_text='Cancel' - ) }} - {% else %} - {{ page_footer('Send invitation email') }} - {% endif %} + {{ page_footer('Send invitation email') }}