From d7a591836d260bed220e593901b915d3eafdbcb6 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Wed, 31 Aug 2016 12:00:42 +0100 Subject: [PATCH] Revert "Remove check for statistics not being on job" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 40e22d8258dc336f52f64b54f78d3912dce48feb. For some reason jobs don’t always have statistics. --- app/notify_client/job_api_client.py | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/app/notify_client/job_api_client.py b/app/notify_client/job_api_client.py index 10fe9c2f1..bd9f06d57 100644 --- a/app/notify_client/job_api_client.py +++ b/app/notify_client/job_api_client.py @@ -18,14 +18,15 @@ class JobApiClient(BaseAPIClient): @staticmethod def __convert_statistics(job): results = defaultdict(int) - for outcome in job['statistics']: - if outcome['status'] in ['failed', 'technical-failure', 'temporary-failure', 'permanent-failure']: - results['failed'] += outcome['count'] - if outcome['status'] in ['sending', 'pending', 'created']: - results['sending'] += outcome['count'] - if outcome['status'] in ['delivered']: - results['delivered'] += outcome['count'] - results['requested'] += outcome['count'] + if 'statistics' in job: + for outcome in job['statistics']: + if outcome['status'] in ['failed', 'technical-failure', 'temporary-failure', 'permanent-failure']: + results['failed'] += outcome['count'] + if outcome['status'] in ['sending', 'pending', 'created']: + results['sending'] += outcome['count'] + if outcome['status'] in ['delivered']: + results['delivered'] += outcome['count'] + results['requested'] += outcome['count'] return results def get_job(self, service_id, job_id=None, limit_days=None, status=None):