From ecd43cee5e64d34a3f026e02abfb05e33f6d2b2b Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Mon, 20 Nov 2017 16:47:03 +0000 Subject: [PATCH] Fix misleading `

` in one-off flow Changing the `

` in https://github.com/alphagov/notifications-admin/pull/1638 turned out to be quite confusing. The combination of the word "recipient" and a selection of email addresses on the page was confusing. This commit changes the page title to be much more explicit about what is expected from the page, rather than what is consistent with the text of the link that the user clicked. --- app/main/views/send.py | 4 ++-- tests/app/main/views/test_send.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/main/views/send.py b/app/main/views/send.py index e0db1e8d1..31fec2cd7 100644 --- a/app/main/views/send.py +++ b/app/main/views/send.py @@ -217,8 +217,8 @@ def set_sender(service_id, template_id): def get_sender_context(sender_details, template_type): context = { 'email': { - 'title': 'Where should replies go?', - 'description': 'Where should replies go?', + 'title': 'Where should replies come back to?', + 'description': 'Where should replies come back to?', 'field_name': 'email_address' }, 'letter': { diff --git a/tests/app/main/views/test_send.py b/tests/app/main/views/test_send.py index 5de52ebee..3ae9666b0 100644 --- a/tests/app/main/views/test_send.py +++ b/tests/app/main/views/test_send.py @@ -44,8 +44,8 @@ test_non_spreadsheet_files = glob(path.join('tests', 'non_spreadsheet_files', '* ( mock_get_service_email_template, multiple_reply_to_email_addresses, - 'Where should replies go?', - 'Where should replies go?', + 'Where should replies come back to?', + 'Where should replies come back to?', ), ( mock_get_service_template,