darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-23 15:57:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1745 from alphagov/🖨

Browse Source 
Lint for print statements
This commit is contained in:
Chris Hill-Scott
2018-01-05 12:19:22 +00:00
committed by GitHub
parent 2ec71ace5c b24c23fe3b
commit ec265dd2b4
4 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/commands.py
View File

@@ -4,7 +4,7 @@ from flask import current_app
def list_routes(): def list_routes():
"""List URLs of all application routes.""" """List URLs of all application routes."""
for rule in sorted(current_app.url_map.iter_rules(), key=lambda r: r.rule): for rule in sorted(current_app.url_map.iter_rules(), key=lambda r: r.rule):
print("{:10} {}".format(", ".join(rule.methods - set(['OPTIONS', 'HEAD'])), rule.rule)) print("{:10} {}".format(", ".join(rule.methods - set(['OPTIONS', 'HEAD'])), rule.rule)) # noqa
def setup_commands(application): def setup_commands(application):

1
requirements_for_test.txt
View File

@@ -8,3 +8,4 @@ httpretty==0.8.14
beautifulsoup4==4.6.0 beautifulsoup4==4.6.0
freezegun==0.3.9 freezegun==0.3.9
flake8==3.5.0 flake8==3.5.0
flake8-print==3.0.1

2
scripts/run_tests.sh
View File

@@ -28,7 +28,7 @@ if [[ -z "$VIRTUAL_ENV" ]] && [[ -d venv ]]; then
source ./venv/bin/activate source ./venv/bin/activate
fi fi
flake8 . flake8 --enable=T .
display_result $? 1 "Code style check" display_result $? 1 "Code style check"
npm test npm test

2
tests/__init__.py
View File

@@ -368,7 +368,6 @@ def validate_route_permission(mocker,
else: else:
pytest.fail("Invalid method call {}".format(method)) pytest.fail("Invalid method call {}".format(method))
if resp.status_code != response_code: if resp.status_code != response_code:
print(resp.status_code)
pytest.fail("Invalid permissions set for endpoint {}".format(route)) pytest.fail("Invalid permissions set for endpoint {}".format(route))
return resp return resp
@@ -403,6 +402,5 @@ def validate_route_permission_with_client(mocker,
else: else:
pytest.fail("Invalid method call {}".format(method)) pytest.fail("Invalid method call {}".format(method))
if resp.status_code != response_code: if resp.status_code != response_code:
print(resp.status_code)
pytest.fail("Invalid permissions set for endpoint {}".format(route)) pytest.fail("Invalid permissions set for endpoint {}".format(route))
return resp return resp