darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-18 21:49:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

Simplify test for API error with existing user

Browse Source 
This is now covered since we use 'mock_no_users_for_service'.
This commit is contained in:
Ben Thorner
2021-05-25 17:27:30 +01:00
parent c696693785
commit eb343e4937
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/app/main/views/test_accept_invite.py
View File

@@ -11,7 +11,6 @@ from tests.conftest import (
SERVICE_ONE_ID, SERVICE_ONE_ID,
create_active_caseworking_user, create_active_caseworking_user,
create_active_user_with_permissions, create_active_user_with_permissions,
create_api_user_active,
normalize_spaces, normalize_spaces,
) )
@@ -261,16 +260,12 @@ def test_accept_invite_redirects_if_api_raises_an_error_that_they_are_already_pa
mocker, mocker,
api_user_active, api_user_active,
sample_invite, sample_invite,
mock_get_existing_user_by_email,
mock_accept_invite, mock_accept_invite,
mock_get_service, mock_get_service,
mock_no_users_for_service, mock_no_users_for_service,
mock_get_user, mock_get_user,
): ):
sample_invite['email_address'] = api_user_active['email_address']
# This mock needs to return a user with a different ID to the invited user so that
# `existing_user in Users(invited_user.service)` returns False and the right code path is tested
mocker.patch('app.user_api_client.get_user_by_email', return_value=create_api_user_active(with_unique_id=True))
mocker.patch('app.invite_api_client.check_token', return_value=sample_invite) mocker.patch('app.invite_api_client.check_token', return_value=sample_invite)
mock_audit_event = mocker.patch('app.event_handlers.create_add_user_to_service_event') mock_audit_event = mocker.patch('app.event_handlers.create_add_user_to_service_event')