Add tests for getting a user’s phone number

Also makes the code a bit more specific by not squashing any exception,
only `HTTPError`s.
This commit is contained in:
Chris Hill-Scott
2017-06-14 15:37:57 +01:00
parent bff9365d1b
commit eabd3f551a
2 changed files with 61 additions and 1 deletions

View File

@@ -8,6 +8,7 @@ from notifications_utils.template import SMSPreviewTemplate
from app.main import main
from app.utils import user_has_permissions
from app import notification_api_client, service_api_client
from notifications_python_client.errors import HTTPError
@main.route("/services/<service_id>/conversation/<notification_id>")
@@ -27,7 +28,7 @@ def conversation(service_id, notification_id):
def get_user_number(service_id, notification_id):
try:
user_number = service_api_client.get_inbound_sms_by_id(service_id, notification_id)['user_number']
except Exception:
except HTTPError:
user_number = notification_api_client.get_notification(service_id, notification_id)['to']
return format_phone_number_human_readable(user_number)