darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-17 04:59:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

Only put the overlay on bad pages

Browse Source 
This will make it easier to find errors in your file, because you won’t
spent time looking for them on pages which are OK.
This commit is contained in:
Chris Hill-Scott
2020-01-13 16:40:47 +00:00
parent bf56a9bac1
commit e9ad2e9c42
2 changed files with 58 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
app/main/views/uploads.py
View File

@@ -241,11 +241,19 @@ def uploaded_letter_preview(service_id, file_id):
@main.route("/services/<uuid:service_id>/preview-letter-image/<uuid:file_id>")
@user_has_permissions('send_messages')
def view_letter_upload_as_preview(service_id, file_id):
try:
page = int(request.args.get('page'))
except ValueError:
abort(400)
pdf_file, metadata = get_letter_pdf_and_metadata(service_id, file_id)
invalid_pages = json.loads(metadata.get('invalid_pages', '[]'))
page = request.args.get('page')
if metadata.get('message') == 'content-outside-printable-area':
if (
metadata.get('message') == 'content-outside-printable-area' and
page in invalid_pages
):
return TemplatePreview.from_invalid_pdf_file(pdf_file, page)
else:
return TemplatePreview.from_valid_pdf_file(pdf_file, page)