darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-19 14:09:20 -04:00
Code Issues Packages Projects Releases Wiki Activity

Change folder viewing permissions from manage folder page

Browse Source
This commit is contained in:
Pea Tyczynska
2019-03-15 17:19:18 +00:00
parent 1ab36dd026
commit e85969f6fa
6 changed files with 57 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
tests/app/main/views/test_template_folders.py
View File

@@ -454,7 +454,7 @@ def test_get_manage_folder_page(
assert "Users who can see this folder:" in form_labels[0].text
checkboxes = page.select('input[name=viewing_permissions]')
assert len(checkboxes) == 1
assert checkboxes[0]['value'] == 'y'
assert checkboxes[0]['value'] == active_user_with_permissions.id
assert "Test User" in page.findAll('label', {'for': 'viewing_permissions-0'})[0].text
@@ -494,7 +494,7 @@ def test_rename_folder(client_request, active_user_with_permissions, service_one
'main.manage_template_folder',
service_id=service_one['id'],
template_folder_id=folder_id,
_data={"name": "new beautiful name"},
_data={"name": "new beautiful name", "viewing_permissions": [active_user_with_permissions.id]},
_expected_redirect=url_for("main.choose_template",
service_id=service_one['id'],
template_folder_id=folder_id,
@@ -504,7 +504,39 @@ def test_rename_folder(client_request, active_user_with_permissions, service_one
mock_update.assert_called_once_with(
service_one['id'],
folder_id,
name="new beautiful name"
name="new beautiful name",
users_with_permission=[active_user_with_permissions.id]
)
def test_manage_folder_users(
client_request, active_user_with_permissions, service_one, mock_get_template_folders, mocker
):
mock_update = mocker.patch('app.template_folder_api_client.update_template_folder')
folder_id = str(uuid.uuid4())
mock_get_template_folders.return_value = [
{'id': folder_id, 'name': 'folder_two', 'parent_id': None, 'users_with_permission': [
active_user_with_permissions.id
]}
]
mocker.patch('app.models.service.Service.get_team_member', return_value=active_user_with_permissions)
client_request.post(
'main.manage_template_folder',
service_id=service_one['id'],
template_folder_id=folder_id,
_data={"name": "new beautiful name", "viewing_permissions": []},
_expected_redirect=url_for("main.choose_template",
service_id=service_one['id'],
template_folder_id=folder_id,
_external=True)
)
mock_update.assert_called_once_with(
service_one['id'],
folder_id,
name="new beautiful name",
users_with_permission=[]
)

4
tests/app/notify_client/test_template_folder_client.py
View File

@@ -111,13 +111,13 @@ def test_update_template_folder_calls_correct_api_endpoint(mocker):
some_service_id = uuid.uuid4()
template_folder_id = uuid.uuid4()
expected_url = '/service/{}/template-folder/{}'.format(some_service_id, template_folder_id)
data = {'name': 'foo'}
data = {'name': 'foo', 'users_with_permission': ['some_id']}
client = TemplateFolderAPIClient()
mock_post = mocker.patch('app.notify_client.template_folder_api_client.TemplateFolderAPIClient.post')
client.update_template_folder(some_service_id, template_folder_id, name='foo')
client.update_template_folder(some_service_id, template_folder_id, name='foo', users_with_permission=['some_id'])
mock_post.assert_called_once_with(expected_url, data)
mock_redis_delete.assert_called_once_with('service-{}-template-folders'.format(some_service_id))