darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-26 17:24:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refactor test assertions

Browse Source 
Doing this to reduce the use of overly verbose `call()` to match
assertions in test_status_api_client.
This commit is contained in:
David McDonald
2021-12-08 15:45:50 +00:00
parent 20cc1e230f
commit e7d8918f7f
1 changed files with 9 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
tests/app/notify_client/test_performance_platform_api_client.py
View File

@@ -1,5 +1,4 @@
from datetime import date from datetime import date
from unittest.mock import call
from app.notify_client.performance_dashboard_api_client import ( from app.notify_client.performance_dashboard_api_client import (
PerformanceDashboardAPIClient, PerformanceDashboardAPIClient,
@@ -42,21 +41,15 @@ def test_sets_value_in_cache(mocker):
end_date=date(2022, 2, 2), end_date=date(2022, 2, 2),
) == {'data_from': 'api'} ) == {'data_from': 'api'}
assert mock_redis_get.call_args_list == [ mock_redis_get.assert_called_once_with('performance-stats-2021-01-01-to-2022-02-02')
call('performance-stats-2021-01-01-to-2022-02-02'), mock_api_get.assert_called_once_with('/performance-dashboard', params={
]
assert mock_api_get.call_args_list == [
call('/performance-dashboard', params={
'start_date': '2021-01-01', 'end_date': '2022-02-02' 'start_date': '2021-01-01', 'end_date': '2022-02-02'
}), })
] mock_redis_set.assert_called_once_with(
assert mock_redis_set.call_args_list == [ 'performance-stats-2021-01-01-to-2022-02-02',
call( '{"data_from": "api"}',
'performance-stats-2021-01-01-to-2022-02-02', ex=3600,
'{"data_from": "api"}', )
ex=3600,
),
]
def test_returns_value_from_cache(mocker): def test_returns_value_from_cache(mocker):
@@ -78,8 +71,6 @@ def test_returns_value_from_cache(mocker):
end_date=date(2022, 2, 2), end_date=date(2022, 2, 2),
) == {'data_from': 'cache'} ) == {'data_from': 'cache'}
assert mock_redis_get.call_args_list == [ mock_redis_get.assert_called_once_with('performance-stats-2021-01-01-to-2022-02-02')
call('performance-stats-2021-01-01-to-2022-02-02'),
]
assert mock_api_get.called is False assert mock_api_get.called is False
assert mock_redis_set.called is False assert mock_redis_set.called is False