darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-04 05:31:44 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add descriptive links to /service-settings/letter-contact-details

Browse Source 
The links had no descriptive text, so all read 'Change'. This adds
hidden text specific to the item they relate to.
This commit is contained in:
Katie Smith
2021-02-23 14:45:05 +00:00
parent 4f7b08512a
commit e7d6a2ea0d
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/app/main/views/test_service_settings.py
View File

@@ -2191,7 +2191,7 @@ def test_and_more_hint_appears_on_settings_with_more_than_just_a_single_sender(
@pytest.mark.parametrize('sender_list_page, index, expected_output', [
('main.service_email_reply_to', 0, 'test@example.com (default) Change test@example.com'),
('main.service_letter_contact_details', 1, '1 Example Street (default) Change'),
('main.service_letter_contact_details', 1, '1 Example Street (default) Change 1 Example Street'),
('main.service_sms_senders', 0, 'GOVUK (default) Change GOVUK')
])
def test_api_ids_dont_show_on_option_pages_with_a_single_sender(
@@ -2237,9 +2237,9 @@ def test_api_ids_dont_show_on_option_pages_with_a_single_sender(
create_multiple_letter_contact_blocks(),
[
'Blank Make default',
'1 Example Street (default) Change ID: 1234',
'2 Example Street Change ID: 5678',
'foo<bar>baz Change ID: 9457',
'1 Example Street (default) Change 1 Example Street ID: 1234',
'2 Example Street Change 2 Example Street ID: 5678',
'foo<bar>baz Change foo <bar> baz ID: 9457',
],
), (
'main.service_sms_senders',