darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-07 03:48:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

Split out tests for letter and email branding

Browse Source 
This also fills a gap where we weren't checking the central org
case for letters.
This commit is contained in:
Ben Thorner
2022-03-23 13:55:00 +00:00
parent 332c240b01
commit e7d59263d1
1 changed files with 39 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
tests/app/utils/test_branding.py
View File

@@ -30,8 +30,11 @@ def test_get_choices_service_not_assigned_to_org(
assert list(options) == expected_options assert list(options) == expected_options
@pytest.mark.parametrize('function', [get_email_choices, get_letter_choices])
@pytest.mark.parametrize('org_type, expected_options', [ @pytest.mark.parametrize('org_type, expected_options', [
('central', [
('govuk_and_org', 'GOV.UK and Test Organisation'),
('organisation', 'Test Organisation'),
]),
('local', [('organisation', 'Test Organisation')]), ('local', [('organisation', 'Test Organisation')]),
('nhs_central', [('nhs', 'NHS')]), ('nhs_central', [('nhs', 'NHS')]),
('nhs_local', [('nhs', 'NHS')]), ('nhs_local', [('nhs', 'NHS')]),
@@ -39,10 +42,9 @@ def test_get_choices_service_not_assigned_to_org(
('emergency_service', [('organisation', 'Test Organisation')]), ('emergency_service', [('organisation', 'Test Organisation')]),
('other', [('organisation', 'Test Organisation')]), ('other', [('organisation', 'Test Organisation')]),
]) ])
def test_get_choices_service_assigned_to_org( def test_get_email_choices_service_assigned_to_org(
mocker, mocker,
service_one, service_one,
function,
org_type, org_type,
expected_options, expected_options,
mock_get_service_organisation, mock_get_service_organisation,
@@ -54,26 +56,13 @@ def test_get_choices_service_assigned_to_org(
return_value=organisation_json(organisation_type=org_type) return_value=organisation_json(organisation_type=org_type)
) )
options = function(service) options = get_email_choices(service)
assert list(options) == expected_options assert list(options) == expected_options
@pytest.mark.parametrize('service_branding, expected_options', [ def test_get_email_choices_central_org_includes_govuk(
(None, [
('govuk_and_org', 'GOV.UK and Test Organisation'),
('organisation', 'Test Organisation'),
]),
('some-random-branding', [
('govuk', 'GOV.UK'), # central orgs can switch back to GOV.UK
('govuk_and_org', 'GOV.UK and Test Organisation'),
('organisation', 'Test Organisation'),
])
])
def test_get_email_choices_central_org(
mocker, mocker,
service_one, service_one,
service_branding,
expected_options,
mock_get_service_organisation, mock_get_service_organisation,
mock_get_email_branding, mock_get_email_branding,
): ):
@@ -86,10 +75,40 @@ def test_get_email_choices_central_org(
mocker.patch( mocker.patch(
'app.models.service.Service.email_branding_id', 'app.models.service.Service.email_branding_id',
new_callable=PropertyMock, new_callable=PropertyMock,
return_value=service_branding, return_value='some-random-branding',
) )
options = get_email_choices(service) assert list(get_email_choices(service)) == [
('govuk', 'GOV.UK'), # central orgs can switch back to GOV.UK
('govuk_and_org', 'GOV.UK and Test Organisation'),
('organisation', 'Test Organisation'),
]
@pytest.mark.parametrize('org_type, expected_options', [
('central', [('organisation', 'Test Organisation')]),
('local', [('organisation', 'Test Organisation')]),
('nhs_central', [('nhs', 'NHS')]),
('nhs_local', [('nhs', 'NHS')]),
('nhs_gp', [('nhs', 'NHS')]),
('emergency_service', [('organisation', 'Test Organisation')]),
('other', [('organisation', 'Test Organisation')]),
])
def test_get_letter_choices_service_assigned_to_org(
mocker,
service_one,
org_type,
expected_options,
mock_get_service_organisation,
):
service = Service(service_one)
mocker.patch(
'app.organisations_client.get_organisation',
return_value=organisation_json(organisation_type=org_type)
)
options = get_letter_choices(service)
assert list(options) == expected_options assert list(options) == expected_options