darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-23 07:46:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refactor list comprehension

Browse Source
This commit is contained in:
Andrew Shumway
2023-11-20 10:39:39 -07:00
parent f51d4be8de
commit e7a3b98fff
1 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
app/main/views/send.py
View File

@@ -268,19 +268,27 @@ def remove_notify_from_sender_options(sender_details):
# Remove US Notify/Notify.gov from users list of sender # Remove US Notify/Notify.gov from users list of sender
# options during message send flow # options during message send flow
sender_details = [ sender_details = [
sender sender for sender in sender_details if verify_sender_options(sender)
for sender in sender_details
if sender.get("sms_sender") in ["Notify.gov", "US Notify"]
and sender["is_default"]
or sender.get("sms_sender") not in ["Notify.gov", "US Notify"]
and not sender["is_default"]
or sender.get("sms_sender") not in ["Notify.gov", "US Notify"]
and sender["is_default"]
] ]
return sender_details return sender_details
def verify_sender_options(sender):
if sender.get("sms_sender") in ["Notify.gov", "US Notify"] and sender["is_default"]:
return True
if (
sender.get("sms_sender") not in ["Notify.gov", "US Notify"]
and not sender["is_default"]
):
return True
if (
sender.get("sms_sender") not in ["Notify.gov", "US Notify"]
and sender["is_default"]
):
return True
def get_sender_context(sender_details, template_type): def get_sender_context(sender_details, template_type):
context = { context = {
"email": { "email": {