darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-20 14:29:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use chevrons not slashes to separate folders

Browse Source 
It looks weird to have two different visual treatments for showing a
navigable hierarchy.

I reckon losing the slash won’t make things less folder like – Windows
for example uses chevrons as foler separators.
This commit is contained in:
Chris Hill-Scott
2019-06-24 16:02:49 +01:00
parent acd992183c
commit e731dd70d1
8 changed files with 105 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/app/models/test_service.py
View File

@@ -80,13 +80,13 @@ def test_get_user_template_folders_only_returns_folders_visible_to_user(
result = service.get_user_template_folders(User(active_user_with_permissions))
assert result == [
{
'name': "Parent 1 - invisible / 1's Visible child",
'name': ["Parent 1 - invisible", "1's Visible child"],
'id': mocker.ANY,
'parent_id': None,
'users_with_permission': [active_user_with_permissions['id']],
},
{
'name': "Parent 1 - invisible / 1's Invisible child / 1's Visible grandchild",
'name': ["Parent 1 - invisible", ["1's Invisible child", "1's Visible grandchild"]],
'id': mocker.ANY,
'parent_id': None,
'users_with_permission': [active_user_with_permissions['id']],
@@ -98,7 +98,7 @@ def test_get_user_template_folders_only_returns_folders_visible_to_user(
'users_with_permission': [active_user_with_permissions['id']],
},
{
'name': "2's Invisible child / 2's Visible grandchild",
'name': ["2's Invisible child", "2's Visible grandchild"],
'id': mocker.ANY,
'parent_id': VIS_PARENT_FOLDER_ID,
'users_with_permission': [active_user_with_permissions['id']],
@@ -124,13 +124,13 @@ def test_get_template_folders_shows_user_folders_when_user_id_passed_in(
result = service.get_template_folders(user=User(active_user_with_permissions))
assert result == [
{
'name': "Parent 1 - invisible / 1's Visible child",
'name': ["Parent 1 - invisible", "1's Visible child"],
'id': mocker.ANY,
'parent_id': None,
'users_with_permission': [active_user_with_permissions['id']]
},
{
'name': "Parent 1 - invisible / 1's Invisible child / 1's Visible grandchild",
'name': ["Parent 1 - invisible", ["1's Invisible child", "1's Visible grandchild"]],
'id': mocker.ANY,
'parent_id': None,
'users_with_permission': [active_user_with_permissions['id']]