darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-15 15:28:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add antivirus scan to letter validation preview view

Browse Source
This commit is contained in:
Pea Tyczynska
2018-10-03 17:59:14 +01:00
parent a61393a68e
commit e6e363ba3f
5 changed files with 61 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
tests/app/main/views/test_platform_admin.py
View File

@@ -7,7 +7,7 @@ from unittest.mock import ANY
import pytest
import requests_mock
from bs4 import BeautifulSoup
from flask import url_for, current_app
from flask import current_app, url_for
from freezegun import freeze_time
from app.main.views.platform_admin import (
@@ -779,6 +779,8 @@ def test_letter_validation_preview_calls_template_preview_when_data_correct_and_
mock_get_user(mocker, user=platform_admin_user)
client.login(platform_admin_user)
endpoint = '{}/precompiled/validate?include_preview=true'.format(current_app.config['TEMPLATE_PREVIEW_API_HOST'])
mocker.patch('app.main.views.platform_admin.antivirus_client.scan', return_value=True)
with requests_mock.mock() as rmock:
rmock.request(
"POST",
@@ -803,6 +805,7 @@ def test_letter_validation_preview_calls_template_preview_when_data_correct_and_
def test_letter_validation_preview_doesnt_call_template_preview_when_no_file(mocker, client, platform_admin_user):
mock_get_user(mocker, user=platform_admin_user)
client.login(platform_admin_user)
antivirus_scan = mocker.patch('app.main.views.platform_admin.antivirus_client.scan')
validate_letter = mocker.patch('app.main.views.platform_admin.validate_letter')
response = client.post(
url_for('main.platform_admin_letter_validation_preview'),
@@ -810,6 +813,7 @@ def test_letter_validation_preview_doesnt_call_template_preview_when_no_file(moc
content_type='multipart/form-data'
)
assert response.status_code == 200
antivirus_scan.assert_not_called()
validate_letter.assert_not_called()
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
@@ -819,6 +823,7 @@ def test_letter_validation_preview_doesnt_call_template_preview_when_no_file(moc
def test_letter_validation_preview_doesnt_call_template_preview_when_file_not_pdf(mocker, client, platform_admin_user):
mock_get_user(mocker, user=platform_admin_user)
client.login(platform_admin_user)
antivirus_scan = mocker.patch('app.main.views.platform_admin.antivirus_client.scan')
validate_letter = mocker.patch('app.main.views.platform_admin.validate_letter')
with open('tests/non_spreadsheet_files/actually_a_png.csv', 'rb') as file:
response = client.post(
@@ -827,6 +832,29 @@ def test_letter_validation_preview_doesnt_call_template_preview_when_file_not_pd
content_type='multipart/form-data'
)
assert response.status_code == 200
antivirus_scan.assert_not_called()
validate_letter.assert_not_called()
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
assert page.find('span', class_='error-message').text.strip() == "PDF documents only!"
def test_letter_validation_preview_doesnt_call_template_preview_when_file_doesnt_pass_virus_scan(
mocker, client, platform_admin_user
):
mock_get_user(mocker, user=platform_admin_user)
client.login(platform_admin_user)
antivirus_scan = mocker.patch('app.main.views.platform_admin.antivirus_client.scan', return_value=False)
validate_letter = mocker.patch('app.main.views.platform_admin.validate_letter')
with open('tests/test_pdf_files/multi_page_pdf.pdf', 'rb') as file:
response = client.post(
url_for('main.platform_admin_letter_validation_preview'),
data={"file": file},
content_type='multipart/form-data'
)
assert response.status_code == 400
assert antivirus_scan.called is True
validate_letter.assert_not_called()
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
assert page.find('div', class_='banner-dangerous').text.strip() == "Document didn't pass the virus scan"