darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-17 21:19:38 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add a user method to check folder permission

Browse Source 
User model is the most natural place for a permission check method,
however this means that we need to pass the full user object to
service model methods and TemplateList instead of user_id.
This commit is contained in:
Alexey Bezhan
2019-03-11 14:13:56 +00:00
parent 0f9207a161
commit e6d7f7ebeb
7 changed files with 42 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/app/models/test_service.py
View File

@@ -76,7 +76,7 @@ def test_get_user_template_folders_only_returns_folders_visible_to_user(
mock_get_template_folders.return_value = _get_all_folders(active_user_with_permissions)
service_one['permissions'] = ['edit_folder_permissions']
service = Service(service_one)
result = service.get_user_template_folders(active_user_with_permissions.id)
result = service.get_user_template_folders(active_user_with_permissions)
assert result == [
{
'name': "Parent 1 - invisible / 1's Visible child",
@@ -120,7 +120,7 @@ def test_get_template_folders_shows_user_folders_when_user_id_passed_in(
mock_get_template_folders.return_value = _get_all_folders(active_user_with_permissions)
service_one['permissions'] = ['edit_folder_permissions']
service = Service(service_one)
result = service.get_template_folders(user_id=active_user_with_permissions.id)
result = service.get_template_folders(user=active_user_with_permissions)
assert result == [
{
'name': "Parent 1 - invisible / 1's Visible child",