darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-09 00:43:11 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3691 from alphagov/redis-bug

Browse Source 
Fix incorrect redis key deleting
This commit is contained in:
David McDonald
2020-10-21 11:26:36 +01:00
committed by GitHub
parent 882baadfe3 922d43ea1a
commit e6c02db470
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/notify_client/service_api_client.py
View File

@@ -10,7 +10,7 @@ class ServiceAPIClient(NotifyAdminAPIClient):
templates_for_service = self.get_service_templates(service_id)['data'] templates_for_service = self.get_service_templates(service_id)['data']
if templates_for_service: if templates_for_service:
redis_client.delete(*[ redis_client.delete(*[
f"template-{x['id']}-version-None" f"service-{service_id}-template-{x['id']}-version-None"
for x in templates_for_service for x in templates_for_service
]) ])

2
tests/app/notify_client/test_service_api_client.py
View File

@@ -550,5 +550,5 @@ def test_client_deletes_service_template_cache_when_service_is_updated(
templates_to_delete = mock_redis_delete.call_args_list[0][0] templates_to_delete = mock_redis_delete.call_args_list[0][0]
assert len(templates_to_delete) == 6 assert len(templates_to_delete) == 6
for template_key in templates_to_delete: for template_key in templates_to_delete:
assert template_key.startswith('template-') assert template_key.startswith(f'service-{SERVICE_ONE_ID}-template')
assert template_key.endswith('version-None') assert template_key.endswith('version-None')