darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-24 00:07:02 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1240 from alphagov/add-international-sms-feature-flag

Browse Source 
Add international sms feature flag
This commit is contained in:
kentsanggds
2017-04-25 19:09:07 +01:00
committed by GitHub
parent 0e8ae2c8ca d958a58b1b
commit e37ce051e7
5 changed files with 54 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/__init__.py
View File

@@ -50,6 +50,7 @@ def service_json(
sms_sender=None,
research_mode=False,
can_send_letters=False,
can_send_international_sms=False,
organisation=None,
branding='govuk',
created_at=None,
@@ -69,6 +70,7 @@ def service_json(
'sms_sender': sms_sender,
'research_mode': research_mode,
'can_send_letters': can_send_letters,
'can_send_international_sms': can_send_international_sms,
'organisation': organisation,
'branding': branding,
'created_at': created_at or str(datetime.utcnow()),

35
tests/app/main/views/test_service_settings.py
View File

@@ -417,6 +417,7 @@ def test_route_permissions(
'main.service_switch_live',
'main.service_switch_research_mode',
'main.service_switch_can_send_letters',
'main.service_switch_can_send_international_sms',
'main.archive_service',
])
def test_route_invalid_permissions(
@@ -467,6 +468,7 @@ def test_route_for_platform_admin(
'main.service_switch_live',
'main.service_switch_research_mode',
'main.service_switch_can_send_letters',
'main.service_switch_can_send_international_sms',
])
def test_route_for_platform_admin_update_service(
mocker,
@@ -845,6 +847,39 @@ def test_switch_service_disable_letters(
assert mocked_fn.call_args == call(service_one['id'], {"can_send_letters": False})
def test_switch_service_enable_international_sms(
logged_in_platform_admin_client,
service_one,
mocker,
):
mocked_fn = mocker.patch('app.service_api_client.update_service_with_properties', return_value=service_one)
response = logged_in_platform_admin_client.get(
url_for('main.service_switch_can_send_international_sms', service_id=service_one['id'])
)
assert response.status_code == 302
assert response.location == url_for('main.service_settings', service_id=service_one['id'], _external=True)
assert mocked_fn.call_args == call(service_one['id'], {'can_send_international_sms': True})
def test_switch_service_disable_international_sms(
logged_in_platform_admin_client,
service_one,
mocker,
):
service_one['can_send_international_sms'] = True
mocked_fn = mocker.patch('app.service_api_client.update_service_with_properties', return_value=service_one)
response = logged_in_platform_admin_client.get(
url_for('main.service_switch_can_send_international_sms', service_id=service_one['id'])
)
assert response.status_code == 302
assert response.location == url_for('main.service_settings', service_id=service_one['id'], _external=True)
assert mocked_fn.call_args == call(service_one['id'], {"can_send_international_sms": False})
def test_archive_service_after_confirm(
logged_in_platform_admin_client,
service_one,