darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-09 14:29:49 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove the title from the short errors

Browse Source 
This undoes some of the temporary work we did previously in order to
ship the new ‘address is empty’ error message.
This commit is contained in:
Chris Hill-Scott
2020-01-10 17:00:42 +00:00
parent bf56a9bac1
commit e3670de6c4
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/templates/views/notifications/notification.html
View File

@@ -44,7 +44,7 @@
</p> </p>
{% elif notification_status == 'validation-failed' %} {% elif notification_status == 'validation-failed' %}
<p class="notification-status-cancelled"> <p class="notification-status-cancelled">
Validation failed – {{ message.title | safe }}. {{ message.detail | safe }} Validation failed. {{ message.detail | safe }}
</p> </p>
{% elif notification_status == 'technical-failure' %} {% elif notification_status == 'technical-failure' %}
<p class="notification-status-cancelled"> <p class="notification-status-cancelled">

7
tests/app/main/views/test_notifications.py
View File

@@ -331,9 +331,10 @@ def test_notification_page_shows_validation_failed_precompiled_letter(
) )
error_message = page.find('p', class_='notification-status-cancelled').text error_message = page.find('p', class_='notification-status-cancelled').text
assert normalize_spaces(error_message) == \ assert normalize_spaces(error_message) == (
"Validation failed – Your content is outside the printable area. " \ 'Validation failed. You need to edit page 1.'
"You need to edit page 1.Files must meet our letter specification." 'Files must meet our letter specification.'
)
assert not page.select('p.notification-status') assert not page.select('p.notification-status')