Address PR feedback

This commit is contained in:
Ryan Ahearn
2023-03-14 16:00:40 -04:00
parent 67b64f11b9
commit e3610f7d9d
5 changed files with 40 additions and 35 deletions

View File

@@ -4,12 +4,7 @@ If you're working in VS Code, you can also leverage Docker for a containerized d
1. Get the API running, including the Docker network
1. Create the .env file
```
cp sample.env .env
# follow the instructions in .env
```
1. Uncomment the `Local Docker setup` lines in `.env` and comment out the `Local direct setup` lines.
1. Install the Remote-Containers plug-in in VS Code
@@ -23,4 +18,4 @@ If you're working in VS Code, you can also leverage Docker for a containerized d
1. Go to http://localhost:6012
NOTE: when you change .env in the future, you'll need to rebuild the devcontainer for the change to take effect. VS Code _should_ detect the change and prompt you with a toast notification during a cached build. If not, you can find a manual rebuild in command pallette or just `docker rm` the notifications-api container.
NOTE: when you change .env in the future, you'll need to rebuild the devcontainer for the change to take effect. VS Code _should_ detect the change and prompt you with a toast notification during a cached build. If not, you can find a manual rebuild in command pallette or just `docker rm` the notifications-api container.