Merge pull request #879 from alphagov/more_wording_changes

Changed some more instances of "confirmation" code to "security" code
This commit is contained in:
minglis
2016-08-22 13:31:51 +01:00
committed by GitHub
7 changed files with 9 additions and 9 deletions

View File

@@ -337,7 +337,7 @@ class ServiceSmsSender(Form):
def validate_sms_sender(form, field): def validate_sms_sender(form, field):
import re import re
if field.data and not re.match('^[a-zA-Z0-9\s]+$', field.data): if field.data and not re.match('^[a-zA-Z0-9\s]+$', field.data):
raise ValidationError('Sms text message sender can only contain alpha-numeric characters') raise ValidationError('Text message sender can only contain alpha-numeric characters')
class ServiceBrandingOrg(Form): class ServiceBrandingOrg(Form):

View File

@@ -12,7 +12,7 @@ Check your mobile number GOV.UK Notify
<div class="column-two-thirds"> <div class="column-two-thirds">
<h1 class="heading-large">Check your mobile number</h1> <h1 class="heading-large">Check your mobile number</h1>
<p>Check your mobile phone number is correct and then resend the confirmation code.</p> <p>Check your mobile phone number is correct and then resend the security code.</p>
<p> <p>
<label class="form-label" for="mobile">Mobile phone number</label> <label class="form-label" for="mobile">Mobile phone number</label>
@@ -21,7 +21,7 @@ Check your mobile number GOV.UK Notify
<p> <p>
<a class="button" href="verify-mobile" role="button">Resend confirmation code</a> <a class="button" href="verify-mobile" role="button">Resend security code</a>
</p> </p>
</div> </div>
</div> </div>

View File

@@ -12,11 +12,11 @@ Check your mobile number GOV.UK Notify
<div class="column-two-thirds"> <div class="column-two-thirds">
<h1 class="heading-large">Check your mobile number</h1> <h1 class="heading-large">Check your mobile number</h1>
<p>Check your mobile phone number is correct and then resend the confirmation code.</p> <p>Check your mobile phone number is correct and then resend the security code.</p>
<form autocomplete="off" method="post"> <form autocomplete="off" method="post">
{{ textbox(form.mobile_number) }} {{ textbox(form.mobile_number) }}
{{ page_footer("Resend confirmation code") }} {{ page_footer("Resend security code") }}
</form> </form>
</div> </div>
</div> </div>

View File

@@ -13,7 +13,7 @@ GOV.UK Notify | Service settings
<div class="grid-row"> <div class="grid-row">
<div class="column-three-quarters"> <div class="column-three-quarters">
<p> <p>
Weve sent a code to your new {{ thing }}. Weve sent a security code to your new {{ thing }}.
</p> </p>
<form method="post"> <form method="post">
{{ textbox(form_field) }} {{ textbox(form_field) }}

View File

@@ -10,7 +10,7 @@ Confirm your mobile number GOV.UK Notify
<div class="column-two-thirds"> <div class="column-two-thirds">
<h1 class="heading-large">Confirm your mobile number</h1> <h1 class="heading-large">Confirm your mobile number</h1>
<p>Weve sent you a security code by text message.</p> <p>Weve sent you a security code by text message.</p>
<p> <p>
<label class="form-label" for="email">Enter security code<br> <label class="form-label" for="email">Enter security code<br>

View File

@@ -141,4 +141,4 @@ def test_sms_sender_form_validation(app_, mock_get_user_by_email):
form.sms_sender.data = '###########' form.sms_sender.data = '###########'
form.validate() form.validate()
assert 'Sms text message sender can only contain alpha-numeric characters' == form.errors['sms_sender'][0] assert 'Text message sender can only contain alpha-numeric characters' == form.errors['sms_sender'][0]

View File

@@ -66,7 +66,7 @@ def test_should_render_correct_resend_template_for_pending_user(app_,
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser') page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
assert page.h1.string == 'Check your mobile number' assert page.h1.string == 'Check your mobile number'
expected = 'Check your mobile phone number is correct and then resend the confirmation code.' expected = 'Check your mobile phone number is correct and then resend the security code.'
message = page.find_all('p')[1].text message = page.find_all('p')[1].text
assert message == expected assert message == expected
assert page.find('form').input['value'] == api_user_pending.mobile_number assert page.find('form').input['value'] == api_user_pending.mobile_number