darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-18 21:49:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refactor to have separate view for viewing and editing a provider with tests

Browse Source
This commit is contained in:
Imdad Ahad
2017-03-02 22:53:51 +00:00
parent 1047ddae38
commit e20ac9bdc8
2 changed files with 134 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
app/main/views/providers.py
View File

@@ -19,16 +19,16 @@ def view_providers():
email_providers = [email for email in providers if email['notification_type'] == 'email']
sms_providers = [sms for sms in providers if sms['notification_type'] == 'sms']
return render_template(
'views/providers.html',
'views/providers/providers.html',
email_providers=email_providers,
sms_providers=sms_providers
)
@main.route("/provider/<provider_id>", methods=['GET', 'POST'])
@main.route("/provider/<provider_id>/edit", methods=['GET', 'POST'])
@login_required
@user_has_permissions(admin_override=True)
def view_provider(provider_id):
def edit_provider(provider_id):
provider = provider_client.get_provider_by_id(provider_id)['provider_details']
form = ProviderForm(active=provider['active'], priority=provider['priority'])
@@ -36,4 +36,12 @@ def view_provider(provider_id):
provider_client.update_provider(provider_id, form.priority.data)
return redirect(url_for('.view_providers'))
return render_template('views/provider.html', form=form, provider=provider)
return render_template('views/providers/edit-provider.html', form=form, provider=provider)
@main.route("/provider/<provider_id>")
@login_required
@user_has_permissions(admin_override=True)
def view_provider(provider_id):
versions = provider_client.get_provider_versions(provider_id)
return render_template('views/providers/provider.html', provider_versions=versions['data'])