darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-20 22:40:31 -04:00
Code Issues Packages Projects Releases Wiki Activity

Rewrite navigation as a class

Browse Source 
Because we have multiple navigations, which will share the same methods
(by subclassing) but different mappings of navigation items to endpoints
by overriding the `.mapping` and `.exclude` attributes.
This commit is contained in:
Chris Hill-Scott
2018-04-25 10:24:32 +01:00
parent 1fba5d186d
commit e1fd63e184
4 changed files with 263 additions and 246 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tests/app/test_navigation.py
View File

@@ -1,7 +1,7 @@
import pytest
from tests.conftest import SERVICE_ONE_ID, app_
from app import navigation
from app.navigation import MainNavigation
all_endpoints = [
rule.endpoint for rule in next(app_(None)).url_map.iter_rules()
@@ -9,30 +9,30 @@ all_endpoints = [
def test_navigation_items_are_properly_defined():
for endpoint in navigation.endpoints_with_navigation:
for endpoint in MainNavigation().endpoints_with_navigation:
assert endpoint in all_endpoints
assert endpoint not in navigation.endpoints_without_navigation
assert navigation.endpoints_with_navigation.count(endpoint) == 1
assert endpoint not in MainNavigation().endpoints_without_navigation
assert MainNavigation().endpoints_with_navigation.count(endpoint) == 1
def test_excluded_navigation_items_are_properly_defined():
for endpoint in navigation.endpoints_without_navigation:
for endpoint in MainNavigation().endpoints_without_navigation:
assert endpoint in all_endpoints
assert endpoint not in navigation.endpoints_with_navigation
assert navigation.endpoints_without_navigation.count(endpoint) == 1
assert endpoint not in MainNavigation().endpoints_with_navigation
assert MainNavigation().endpoints_without_navigation.count(endpoint) == 1
def test_all_endpoints_are_covered():
for endpoint in all_endpoints:
assert endpoint in (
navigation.endpoints_with_navigation +
navigation.endpoints_without_navigation
MainNavigation().endpoints_with_navigation +
MainNavigation().endpoints_without_navigation
)
@pytest.mark.xfail(raises=KeyError)
def test_raises_on_invalid_navigation_item(client_request):
navigation.nav_selected('foo')
MainNavigation().is_selected('foo')
@pytest.mark.parametrize('endpoint, selected_nav_item', [