From ae0715eee5e7e206aee7f3e1b0f18bf0fa77d699 Mon Sep 17 00:00:00 2001 From: Beverly Nguyen Date: Mon, 16 Jun 2025 15:44:40 -0700 Subject: [PATCH 1/2] comment out user's ability to turn on/off sms --- app/templates/views/service-settings.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/templates/views/service-settings.html b/app/templates/views/service-settings.html index b90545030..d00d8aae5 100644 --- a/app/templates/views/service-settings.html +++ b/app/templates/views/service-settings.html @@ -39,7 +39,7 @@ {% call row() %} {{ text_field('Send text messages') }} {{ boolean_field('sms' in current_service.permissions) }} - {{ edit_field( + {# {{ edit_field( 'Change', url_for( '.service_set_channel', @@ -48,7 +48,7 @@ ), permissions=['manage_service'], suffix='your settings for sending text messages', - )}} + )}} #} {% endcall %} {% if current_user.platform_admin %} From 740cdcd7a3d893cff5c053def1ed07c7dfc67af2 Mon Sep 17 00:00:00 2001 From: Beverly Nguyen Date: Mon, 16 Jun 2025 15:56:43 -0700 Subject: [PATCH 2/2] fix pytest --- .../main/views/service_settings/test_service_settings.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/app/main/views/service_settings/test_service_settings.py b/tests/app/main/views/service_settings/test_service_settings.py index c9234700d..1f04b1315 100644 --- a/tests/app/main/views/service_settings/test_service_settings.py +++ b/tests/app/main/views/service_settings/test_service_settings.py @@ -52,7 +52,7 @@ def _mock_get_service_settings_page_common( [ "", "Service name Test Service Change service name", - "Send text messages On Change your settings for sending text messages", + "Send text messages On", "Start text messages with service name On Change your settings " "for starting text messages with service name", ], @@ -62,7 +62,7 @@ def _mock_get_service_settings_page_common( [ "", "Service name Test Service Change service name", - "Send text messages On Change your settings for sending text messages", + "Send text messages On", "Text message senders (Only visible to Platform Admins) GOVUK Manage text message senders", "Start text messages with service name On Change your settings " "for starting text messages with service name", @@ -190,7 +190,7 @@ def test_send_files_by_email_row_on_settings_page( ["email", "sms", "international_sms"], [ "Service name service one Change service name", - "Send text messages On Change your settings for sending text messages", + "Send text messages On", "Start text messages with service name On Change your settings " "for starting text messages with service name", ], @@ -199,7 +199,7 @@ def test_send_files_by_email_row_on_settings_page( ["email", "sms", "email_auth"], [ "Service name service one Change service name", - "Send text messages On Change your settings for sending text messages", + "Send text messages On", "Start text messages with service name On Change your settings " "for starting text messages with service name", ],