darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-07 18:38:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

Removed "failure" area so the user can get to all the statuses from the Dashboard Landing screen. A better way to view all statuses will come with a Dashboard redesign.

Browse Source
This commit is contained in:
Jonathan Bobel
2024-03-19 12:10:43 -04:00
parent f391b5af2c
commit de003a8722
2 changed files with 3 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
app/templates/views/dashboard/_totals.html
View File

@@ -17,30 +17,9 @@
<a class="usa-button usa-button--outline" href="{{ url_for('.view_notifications', service_id=service_id, message_type='sms', status='sending,delivered,failed') }}"> <a class="usa-button usa-button--outline" href="{{ url_for('.view_notifications', service_id=service_id, message_type='sms', status='sending,delivered,failed') }}">
Details Details
</a> </a>
{% if show_failures %} {# Removing the failures area for now, as the user can click on the above link to see all the details.
<span class="big-number-status{% if statistics['sms']['show_warning'] is sameas true %} big-number-status--failing{% endif %}"> In the future state of the dashboard, the all statuses will be more apparent with data visualizations #}
{% if statistics['sms']['failed'] %}
<a class="usa-link" href="{{ url_for('.view_notifications', service_id=service_id, message_type='sms', status='failed') }}">
{{ "{:,}".format(statistics['sms']['failed']) }}
failed – {{ statistics['sms']['failed_percentage'] }}%
</a>
{% else %}
No failures
{% endif %}
</span>
{% endif %}
</span> </span>
</div> </div>
<!-- <div id="total-email" class="grid-col-6">
<span class="big-number-with-status pilot-disabled">
<a class="usa-link display-block margin-bottom-1">
<span class="big-number-smaller">
<span class="big-number-number">0</span>
<span class="big-number-label">emails sent</span>
</span>
</a>
<span class="big-number-status">No failures</span>
</span>
</div> -->
</div> </div>
</div> </div>

2
tests/app/main/views/test_dashboard.py
View File

@@ -655,7 +655,7 @@ def test_should_not_show_recent_templates_on_dashboard_if_only_one_template_used
expected_count = stats[0]["count"] expected_count = stats[0]["count"]
assert expected_count == 50 assert expected_count == 50
assert normalize_spaces(page.select_one("#total-sms .big-number-smaller").text) == ( assert normalize_spaces(page.select_one("#total-sms .big-number-smaller").text) == (
"{} text messages sent".format(expected_count) "{} text messages sent in the last seven days".format(expected_count)
) )