darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-02-05 02:42:26 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #144 from alphagov/error_headers_fix

Browse Source 
Update error handlers to include appropriate headers.
This commit is contained in:
Adam Shimali
2016-02-02 17:24:43 +00:00
parent b95e08a3a6 7fc1db9d19
commit dd07a00e68
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
app/__init__.py
View File

@@ -3,7 +3,7 @@ import re
import ast import ast
import dateutil import dateutil
from flask import Flask, session, Markup, escape, render_template from flask import (Flask, session, Markup, escape, render_template, make_response)
from flask._compat import string_types from flask._compat import string_types
from flask.ext.sqlalchemy import SQLAlchemy from flask.ext.sqlalchemy import SQLAlchemy
from flask_login import LoginManager from flask_login import LoginManager
@@ -160,7 +160,7 @@ def useful_headers_after_request(response):
if 'Cache-Control' in response.headers: if 'Cache-Control' in response.headers:
del response.headers['Cache-Control'] del response.headers['Cache-Control']
response.headers.add( response.headers.add(
'Cache-Control', 'no-store, max-age=43200, no-cache, private, must-revalidate') 'Cache-Control', 'no-store, no-cache, private, must-revalidate')
return response return response
@@ -168,7 +168,8 @@ def register_errorhandlers(application):
def render_error(error): def render_error(error):
# If a HTTPException, pull the `code` attribute; default to 500 # If a HTTPException, pull the `code` attribute; default to 500
error_code = getattr(error, 'code', 500) error_code = getattr(error, 'code', 500)
return render_template("error/{0}.html".format(error_code)), error_code resp = make_response(render_template("error/{0}.html".format(error_code)), error_code)
return useful_headers_after_request(resp)
for errcode in [401, 404, 500]: for errcode in [401, 404, 500]:
application.errorhandler(errcode)(render_error) application.errorhandler(errcode)(render_error)