darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-18 05:30:21 -04:00
Code Issues Packages Projects Releases Wiki Activity

Continue to remove "roles" terminology

Browse Source 
This renames the two functions we have to translate between UI and
DB permissions, as well as some of their associated variables to
make it clearer which kind of permission they contain.
This commit is contained in:
Ben Thorner
2021-07-22 14:38:45 +01:00
parent ba9865e62e
commit dcfff87cc0
5 changed files with 36 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
tests/app/utils/test_user_permissions.py
View File

@@ -1,12 +1,12 @@
import pytest
from app.utils.user_permissions import (
translate_permissions_from_admin_roles_to_db,
translate_permissions_from_db_to_admin_roles,
translate_permissions_from_db_to_ui,
translate_permissions_from_ui_to_db,
)
@pytest.mark.parametrize('db_roles,admin_roles', [
@pytest.mark.parametrize('db_permissions,expected_ui_permissions', [
(
['approve_broadcasts', 'reject_broadcasts', 'cancel_broadcasts'],
{'approve_broadcasts'},
@@ -28,15 +28,18 @@ from app.utils.user_permissions import (
{'send_messages', 'manage_templates', 'some_unknown_permission'},
),
])
def test_translate_permissions_from_db_to_admin_roles(
db_roles,
admin_roles,
def test_translate_permissions_from_db_to_ui(
db_permissions,
expected_ui_permissions,
):
roles = translate_permissions_from_db_to_admin_roles(db_roles)
assert roles == admin_roles
ui_permissions = translate_permissions_from_db_to_ui(db_permissions)
assert ui_permissions == expected_ui_permissions
def test_translate_permissions_from_admin_roles_to_db():
roles = ['send_messages', 'manage_templates', 'some_unknown_permission']
db_perms = translate_permissions_from_admin_roles_to_db(roles)
assert db_perms == {'send_texts', 'send_emails', 'send_letters', 'manage_templates', 'some_unknown_permission'}
def test_translate_permissions_from_ui_to_db():
ui_permissions = ['send_messages', 'manage_templates', 'some_unknown_permission']
db_permissions = translate_permissions_from_ui_to_db(ui_permissions)
assert db_permissions == {
'send_texts', 'send_emails', 'send_letters', 'manage_templates', 'some_unknown_permission'
}