darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-18 21:49:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

some fixes

Browse Source
This commit is contained in:
Kenneth Kehl
2024-05-16 15:13:45 -07:00
parent 9a83ba7475
commit dcfc78d805
3 changed files with 77 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
tests/notifications_utils/clients/redis/test_redis_client.py
View File

@@ -8,17 +8,17 @@ from freezegun import freeze_time
from notifications_utils.clients.redis.redis_client import RedisClient, prepare_value
@pytest.fixture(scope="function")
@pytest.fixture()
def mocked_redis_pipeline():
return Mock()
@pytest.fixture
@pytest.fixture()
def delete_mock():
return Mock(return_value=4)
@pytest.fixture(scope="function")
@pytest.fixture()
def mocked_redis_client(app, mocked_redis_pipeline, delete_mock, mocker):
app.config["REDIS_ENABLED"] = True
@@ -46,14 +46,16 @@ def mocked_redis_client(app, mocked_redis_pipeline, delete_mock, mocker):
return redis_client
@pytest.fixture
@pytest.fixture()
def failing_redis_client(mocked_redis_client, delete_mock):
mocked_redis_client.redis_store.get.side_effect = Exception("get failed")
mocked_redis_client.redis_store.set.side_effect = Exception("set failed")
mocked_redis_client.redis_store.incr.side_effect = Exception("incr failed")
mocked_redis_client.redis_store.pipeline.side_effect = Exception("pipeline failed")
mocked_redis_client.redis_store.delete.side_effect = Exception("delete failed")
delete_mock.side_effect = Exception("delete by pattern failed")
# nota bene: using KeyError because flake8 thinks Exception
# and BaseException are too broad
mocked_redis_client.redis_store.get.side_effect = KeyError("get failed")
mocked_redis_client.redis_store.set.side_effect = KeyError("set failed")
mocked_redis_client.redis_store.incr.side_effect = KeyError("incr failed")
mocked_redis_client.redis_store.pipeline.side_effect = KeyError("pipeline failed")
mocked_redis_client.redis_store.delete.side_effect = KeyError("delete failed")
delete_mock.side_effect = KeyError("delete by pattern failed")
return mocked_redis_client
@@ -85,27 +87,27 @@ def test_should_raise_exception_if_raise_set_to_true(
app,
failing_redis_client,
):
with pytest.raises(Exception) as e:
with pytest.raises(KeyError) as e:
failing_redis_client.get("test", raise_exception=True)
assert str(e.value) == "get failed"
with pytest.raises(Exception) as e:
with pytest.raises(KeyError) as e:
failing_redis_client.set("test", "test", raise_exception=True)
assert str(e.value) == "set failed"
with pytest.raises(Exception) as e:
with pytest.raises(KeyError) as e:
failing_redis_client.incr("test", raise_exception=True)
assert str(e.value) == "incr failed"
with pytest.raises(Exception) as e:
with pytest.raises(KeyError) as e:
failing_redis_client.exceeded_rate_limit("test", 100, 200, raise_exception=True)
assert str(e.value) == "pipeline failed"
with pytest.raises(Exception) as e:
with pytest.raises(KeyError) as e:
failing_redis_client.delete("test", raise_exception=True)
assert str(e.value) == "delete failed"
with pytest.raises(Exception) as e:
with pytest.raises(KeyError) as e:
failing_redis_client.delete_by_pattern("pattern", raise_exception=True)
assert str(e.value) == "delete by pattern failed"