darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-19 14:09:20 -04:00
Code Issues Packages Projects Releases Wiki Activity

Cancelled notifications do not show as failures on dashboard stats

Browse Source 
Also update tests after we no longer show cancelled letters
This commit is contained in:
Pea Tyczynska
2019-01-08 17:52:01 +00:00
parent 848e88c7ca
commit dcc590ec96
6 changed files with 14 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/app/main/views/test_activity.py
View File

@@ -53,7 +53,7 @@ from tests.conftest import (
'created', 'pending', 'sending', 'pending-virus-check',
'delivered', 'sent', 'returned-letter',
'failed', 'temporary-failure', 'permanent-failure', 'technical-failure',
'virus-scan-failed', 'cancelled',
'virus-scan-failed',
]
),
(
@@ -66,7 +66,7 @@ from tests.conftest import (
),
(
'failed',
['failed', 'temporary-failure', 'permanent-failure', 'technical-failure', 'virus-scan-failed', 'cancelled']
['failed', 'temporary-failure', 'permanent-failure', 'technical-failure', 'virus-scan-failed']
)
]
)

5
tests/app/main/views/test_jobs.py
View File

@@ -157,7 +157,7 @@ def test_jobs_page_doesnt_show_scheduled_on_page_2(
'created', 'pending', 'sending', 'pending-virus-check',
'delivered', 'sent', 'returned-letter',
'failed', 'temporary-failure', 'permanent-failure', 'technical-failure',
'virus-scan-failed', 'cancelled',
'virus-scan-failed',
]
),
(
@@ -170,7 +170,7 @@ def test_jobs_page_doesnt_show_scheduled_on_page_2(
),
(
'failed',
['failed', 'temporary-failure', 'permanent-failure', 'technical-failure', 'virus-scan-failed', 'cancelled']
['failed', 'temporary-failure', 'permanent-failure', 'technical-failure', 'virus-scan-failed']
)
]
)
@@ -340,7 +340,6 @@ def test_should_show_letter_job(
'permanent-failure',
'technical-failure',
'virus-scan-failed',
'cancelled',
],
)

4
tests/app/main/views/test_notifications.py
View File

@@ -202,7 +202,11 @@ def test_notification_page_shows_page_for_letter_notification(
),
(
'validation-failed',
<<<<<<< HEAD
'Validation failed – content is outside the printable area',
=======
'Can’t print this letter – content is outside the printable area.',
>>>>>>> Cancelled notifications do not show as failures on dashboard stats
),
))
@freeze_time("2016-01-01 01:01")