darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-25 16:54:03 -04:00
Code Issues Packages Projects Releases Wiki Activity

Cancelled notifications do not show as failures on dashboard stats

Browse Source 
Also update tests after we no longer show cancelled letters
This commit is contained in:
Pea Tyczynska
2019-01-08 17:52:01 +00:00
parent 848e88c7ca
commit dcc590ec96
6 changed files with 14 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
app/templates/components/big-number.html
View File

@@ -34,8 +34,7 @@
link=None,
show_failures=True,
smaller=False,
smallest=False,
failed_as_cancelled=False
smallest=False
) %}
<div class="big-number-with-status">
{{ big_number(number, label, link=link, smaller=smaller, smallest=smallest) }}
@@ -45,26 +44,14 @@
{% if failure_link %}
<a href="{{ failure_link }}">
{{ "{:,}".format(failures) }}
{% if failed_as_cancelled %}
cancelled
{% else %}
failed – {{ failure_percentage }}%
{% endif %}
failed – {{ failure_percentage }}%
</a>
{% else %}
{{ "{:,}".format(failures) }}
{% if failed_as_cancelled %}
cancelled
{% else %}
failed – {{ failure_percentage }}%
{% endif %}
failed – {{ failure_percentage }}%
{% endif %}
{% else %}
{% if failed_as_cancelled %}
0 cancelled
{% else %}
No failures
{% endif %}
No failures
{% endif %}
</div>
{% endif %}