darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-25 16:54:03 -04:00
Code Issues Packages Projects Releases Wiki Activity

Change test on URL to use urllib methods

Browse Source 
Checking the raw string was breaking the test
sometimes due to it expecting the query parameters
to be in a different order.
This commit is contained in:
Tom Byers
2018-08-08 16:17:22 +01:00
parent 155f6b9626
commit dcc0eb1e52
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/app/main/views/test_service_settings.py
View File

@@ -1,6 +1,7 @@
import uuid import uuid
from functools import partial from functools import partial
from unittest.mock import ANY, call from unittest.mock import ANY, call
from urllib.parse import parse_qs, urlparse
import pytest import pytest
from bs4 import BeautifulSoup from bs4 import BeautifulSoup
@@ -1803,10 +1804,14 @@ def test_should_preview_email_branding(
assert response.status_code == 200 assert response.status_code == 200
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser') page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
iframe = page.find('iframe', attrs={"class": "email-branding-preview"}) iframe = page.find('iframe', attrs={"class": "email-branding-preview"})
iframeURLComponents = urlparse(iframe['src'])
iframeQString = parse_qs(iframeURLComponents.query)
assert page.find('input', attrs={"id": "branding_type"})['value'] == 'org' assert page.find('input', attrs={"id": "branding_type"})['value'] == 'org'
assert page.find('input', attrs={"id": "branding_style"})['value'] == '1' assert page.find('input', attrs={"id": "branding_style"})['value'] == '1'
assert iframe and iframe['src'] == '/_email?branding_type=org&branding_style=1' assert iframeURLComponents.path == '/_email'
assert iframeQString['branding_type'] == ['org']
assert iframeQString['branding_style'] == ['1']
app.service_api_client.get_service.assert_called_once_with(service_one['id']) app.service_api_client.get_service.assert_called_once_with(service_one['id'])