darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-26 14:48:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

Make _attach_current_user a pure function

Browse Source 
Mutating dictionaries is gross and doesn’t work as you’d expect. Better
to have the function return a new dictionary instead.

Means we can be explicit that `created_by` is one of the allowed params
when updating a service.
This commit is contained in:
Chris Hill-Scott
2016-08-11 14:20:43 +01:00
parent 0cfe10639a
commit da1fa2e61c
8 changed files with 23 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/notify_client/invite_api_client.py
View File

@@ -23,7 +23,7 @@ class InviteApiClient(BaseAPIClient):
'from_user': invite_from_id,
'permissions': permissions
}
_attach_current_user(data)
data = _attach_current_user(data)
resp = self.post(url='/service/{}/invite'.format(service_id), data=data)
return InvitedUser(**resp['data'])
@@ -40,7 +40,7 @@ class InviteApiClient(BaseAPIClient):
def cancel_invited_user(self, service_id, invited_user_id):
data = {'status': 'cancelled'}
_attach_current_user(data)
data = _attach_current_user(data)
self.post(url='/service/{0}/invite/{1}'.format(service_id, invited_user_id),
data=data)