darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-24 00:07:02 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix argument order bug with page count

Browse Source
This commit is contained in:
Chris Hill-Scott
2017-05-16 11:43:19 +01:00
parent 9820f0db49
commit d9f5884e3d
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/template_previews.py
View File

@@ -39,7 +39,7 @@ def get_page_count_for_letter(template, values=None):
if template['template_type'] != 'letter': if template['template_type'] != 'letter':
return None return None
page_count, _, _ = TemplatePreview.from_database_object(template, values, filetype='json') page_count, _, _ = TemplatePreview.from_database_object(template, 'json', values)
page_count = json.loads(page_count.decode('utf-8'))['count'] page_count = json.loads(page_count.decode('utf-8'))['count']
return page_count return page_count

6
tests/app/test_template_previews.py
View File

@@ -77,11 +77,11 @@ def test_page_count_returns_none_for_non_letter_templates(template_type):
@pytest.mark.parametrize('partial_call, expected_template_preview_args', [ @pytest.mark.parametrize('partial_call, expected_template_preview_args', [
( (
partial(get_page_count_for_letter), partial(get_page_count_for_letter),
({'template_type': 'letter'}, None) ({'template_type': 'letter'}, 'json', None)
), ),
( (
partial(get_page_count_for_letter, values={'foo': 'bar'}), partial(get_page_count_for_letter, values={'foo': 'bar'}),
({'template_type': 'letter'}, {'foo': 'bar'}) ({'template_type': 'letter'}, 'json', {'foo': 'bar'})
), ),
]) ])
def test_page_count_unpacks_from_json_response( def test_page_count_unpacks_from_json_response(
@@ -93,4 +93,4 @@ def test_page_count_unpacks_from_json_response(
mock_template_preview.return_value = (b'{"count": 99}', 200, {}) mock_template_preview.return_value = (b'{"count": 99}', 200, {})
assert partial_call({'template_type': 'letter'}) == 99 assert partial_call({'template_type': 'letter'}) == 99
mock_template_preview.assert_called_once_with(*expected_template_preview_args, filetype='json') mock_template_preview.assert_called_once_with(*expected_template_preview_args)